Skip to content

Added Assert::greaterThan and Assert::lessThan - #53

Merged
frankdekker merged 5 commits into
123inkt:masterfrom
danny-janse:feature/assert/integerGreaterThan
Jun 25, 2025
Merged

Added Assert::greaterThan and Assert::lessThan#53
frankdekker merged 5 commits into
123inkt:masterfrom
danny-janse:feature/assert/integerGreaterThan

Conversation

@danny-janse

Copy link
Copy Markdown
Contributor

New assertion to assert that a value is both integer and has a minimum value.

@bram123

bram123 commented Jun 23, 2025

Copy link
Copy Markdown
Member

Maybe best if this is a separate "greaterThan" method, which does not check the type at all but can be used in combination with Assert::integer/Assert::float/Assert::numeric/Assert::isInstanceOf(BcMath\Number) etc.
And if we're adding a greaterThan method, "lessThan" should be added as well.

@danny-janse danny-janse changed the title Added Assert::integerGreaterThan Added Assert::greaterThan and Assert::lessThan Jun 23, 2025
Comment thread src/Assert.php Outdated
Comment thread src/Assert.php Outdated
@danny-janse
danny-janse requested a review from frankdekker June 25, 2025 12:13
@frankdekker
frankdekker merged commit add87a6 into 123inkt:master Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants