Add assert positive, negative ints - #55
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds four new assertion methods to the Assert class for validating integer values with specific sign constraints. These methods provide more granular validation for positive, negative, non-positive, and non-negative integers.
- Adds four new integer assertion methods:
positiveInt,negativeInt,nonPositiveInt, andnonNegativeInt - Refactors existing integer and numeric tests from
AssertTestto a dedicatedAssertIntegerTestclass - Updates documentation to include the new assertion methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Assert.php | Implements the four new integer assertion methods with proper PHPStan type annotations |
| tests/Unit/AssertIntegerTest.php | Creates new test file with comprehensive tests for all integer-related assertions |
| tests/Unit/AssertTest.php | Removes integer and numeric tests that were moved to the dedicated test file |
| README.md | Documents the new assertion methods in the feature list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bram123
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds assert methods: