Add JsonSerializable in Stringify. - #62
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for handling JsonSerializable objects in the Stringify utility class. When a JsonSerializable object is passed to the Stringify::value() method, it now returns a string in the format ClassName(json_representation).
Changes:
- Added
JsonSerializabletype check in theStringify::value()method that encodes the object usingjson_encode() - Created
MockJsonSerializabletest helper class for testing purposes - Added test case to verify JsonSerializable objects are stringified correctly
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Stringify.php | Adds JsonSerializable import and implements logic to stringify JsonSerializable objects using json_encode with JSON_THROW_ON_ERROR flag |
| tests/Mock/MockJsonSerializable.php | Creates a simple mock class implementing JsonSerializable for testing purposes |
| tests/Unit/StringifyTest.php | Adds test case to verify JsonSerializable objects are properly stringified with expected format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frankdekker
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.