test(electron): fix Windows cleanup and retain packaged smoke diagnostics by 4gray · Pull Request #1665 · 4gray/iptvnator

4gray · 2026-09-22T19:27:25Z

Windows Electron E2E can time out while closing the app, kill only Playwright’s cmd.exe wrapper, and leave Electron holding the temporary profile. A subsequent launch exits before CDP attaches, followed by ECONNRESET, a locked database and worker teardown timeout. Terminate the owned Windows process tree with taskkill /T /F; retain Unix signal escalation. Cleanup retries termination errors and throws unless process exit is confirmed. A real Windows shell/descendant regression runs in the E2E workflow.

Retain the Node child-process handle immediately after source, packaged and raw migration launches, in a WeakMap keyed by the ElectronApplication. Partial restart assignments therefore cannot pair a new application with an old process handle. When Linux exits after its last window closes, Playwright disposes its dispatcher; later electronApp.process() calls throw even after a clean exit. Cleanup now uses the retained handle, including preparation failures, without suppressing unconfirmed-exit errors.

The Linux portable build now uploads frame-copy smoke reports and traces even on failure. Pin the upload action and register its exact SHA in the build-workflow allowlist. The original master smoke failure passed unchanged on rerun and on the previous PR head; its original root cause remains unconfirmed and its assertions are unchanged.

Validation on e85d9befc: the disposed-dispatcher and partial-restart regressions, plus two packaging policy tests, failed before their fixes and passed afterwards. Locally, 272 packaging tests, 504 harness tests and 12 packaged fixture tests passed; the real Windows integration test is skipped on macOS. Three actual macOS E2E scenarios passed: unsaved-settings close/save/relaunch, M3U favorites across restart, and corrupt legacy-profile recovery. Targeted strict TypeScript, E2E lint (0 errors, 156 existing warnings), guidance validation and diff checks passed. Both process-ownership findings were addressed. Fresh reviews on this exact head: Greptile 5/5; Codex found no major issues; zero unresolved review threads. Full CI is still running; merge/release readiness is not yet established.

Updated the Electron debugging guide. No release note: test infrastructure, CI and documentation only; no application behavior change.

chatgpt-codex-connector · 2026-09-22T19:27:38Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-22T21:23:40.131868Z	`e85d9be`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

4gray · 2026-09-22T19:27:52Z

@greptileai

greptile-apps · 2026-09-22T19:31:43Z

Confidence Score: 5/5

The PR appears safe to merge; the earlier cleanup and action-pinning findings are fully addressed and no new actionable defects remain.

Summary

This PR hardens Electron E2E process cleanup and preserves packaged smoke-test diagnostics.

Retains each launched Electron child-process handle in a WeakMap keyed by its application, allowing cleanup after Playwright disposes its process dispatcher and after fixture restart assignments.
Terminates the complete Windows process tree with taskkill /T /F, while retaining Unix signal escalation and requiring confirmed exit.
Adds lifecycle and real Windows process-tree regressions to the E2E workflow.
Uploads Linux portable frame-copy smoke diagnostics on success or failure using a pinned artifact action.
Documents the cleanup and diagnostic workflow.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Launch Electron application] --> B[Capture child process in WeakMap]
    B --> C[Prepare application and run E2E]
    C --> D{Cleanup requested}
    D --> E[Retrieve handle by application identity]
    E --> F{Process already exited?}
    F -- Yes --> G[Cleanup confirmed]
    F -- No --> H[Request Playwright close]
    H --> I{Exit confirmed?}
    I -- Yes --> G
    I -- No --> J[Terminate owned process]
    J --> K{Windows?}
    K -- Yes --> L[taskkill /PID /T /F]
    K -- No --> M[SIGTERM then SIGKILL]
    L --> N{Exit confirmed?}
    M --> N
    N -- Yes --> G
    N -- No --> O[Throw exit-unconfirmed error]

_{Reviews (4) · Last reviewed commit: "test(electron): bind captured processes ..."}

4gray · 2026-09-22T19:35:19Z

@greptileai

4gray · 2026-09-22T21:03:21Z

@codex review

chatgpt-codex-connector · 2026-09-22T21:07:58Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: f48be2ac63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

4gray · 2026-09-22T21:10:25Z

@greptileai

4gray · 2026-09-22T21:10:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5bc36699c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

4gray · 2026-09-22T21:18:34Z

@greptileai

4gray · 2026-09-22T21:18:35Z

@codex review

chatgpt-codex-connector · 2026-09-22T21:23:38Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: e85d9befca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

test(electron): reap Windows process trees and retain smoke diagnostics

19ff9a9

4gray added the no-release-note PR intentionally ships without a .changes/ release note label Sep 22, 2026

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread apps/electron-backend-e2e/src/electron-test-fixtures.ts Outdated

Comment thread .github/workflows/build-and-make.yaml Outdated

test(electron): require confirmed process exit before relaunch

f48be2a

test(electron): retain process handle after application exit

a5bc366

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread apps/electron-backend-e2e/src/electron-test-fixtures.ts Outdated

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread apps/electron-backend-e2e/src/electron-test-fixtures.ts Outdated

test(electron): bind captured processes to application instances

e85d9be

Uh oh!

Conversation

4gray commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

4gray commented Sep 22, 2026

Uh oh!

greptile-apps Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

4gray commented Sep 22, 2026

Uh oh!

4gray commented Sep 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 22, 2026

Uh oh!

4gray commented Sep 22, 2026

Uh oh!

4gray commented Sep 22, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

4gray commented Sep 22, 2026

Uh oh!

4gray commented Sep 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 22, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

4gray commented Sep 22, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 22, 2026 •

edited

Loading

greptile-apps Bot commented Sep 22, 2026 •

edited

Loading