Skip to content

Fix overflow in Tiara bin domain classification softmax (large eukaryotic bins labelled prokarya) - #1140

Merged
prototaxites merged 3 commits into
nf-core:devfrom
Farhana-Anika:Farhana-Anika-patch-1
Nov 15, 2026
Merged

prototaxites merged 3 commits into
nf-core:devfrom
Farhana-Anika:Farhana-Anika-patch-1

Conversation

@Farhana-Anika

@Farhana-Anika Farhana-Anika commented Nov 13, 2026 •

Copy link
Copy Markdown

Closes #1139

bin/domain_classification.R applied a softmax to summed per-contig Tiara probabilities using plain exp(). For bins with many contigs the sums exceed ~709, exp() overflows to Inf, and the probabilities become NaN; which.max() then skips the NaN and falls back to the first class (prokarya). This PR uses the standard log-sum-exp form (subtract the row maximum before exp()), which is mathematically identical but cannot overflow.

  • Results are unchanged for bins that previously did not overflow.
  • Large eukaryotic bins are now correctly classified as eukarya.

Tested on a 2-sample pilot (MEGAHIT + metaSPAdes; MetaBAT2, CONCOCT, SemiBin2): re-running the patched script on the 12 pilot TIARA_CLASSIFY inputs, all 15 bins previously at 0 NA 0 0 changed from prokarya to eukarya (4.4–42.5 Mb; all Chlorophyta by CAT, 4–51% complete by BUSCO chlorophyta_odb10), and the other 94 bins kept their classification. This included two Nitrosomonas bins confirmed by GTDB-Tk, which correctly stayed prokarya.

Acknowledgement

This bug was identified and the fix developed with the assistance of Claude Opus 5.5 (Anthropic), an AI model. I reviewed the change and tested it on our pilot data (see above).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Fix overflow in Tiara bin domain classification softmax

Use log-sum-exp so large eukaryotic bins are no longer labelled prokarya.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 9d9346a

+| ✅ 302 tests passed       |+
#| ❔   6 tests were ignored |#
Details

❔ Tests ignored:

✅ Tests passed:

  • files_exist - File found: .gitattributes
  • files_exist - File found: .gitignore
  • files_exist - File found: .nf-core.yml
  • files_exist - File found: .prettierignore
  • files_exist - File found: .prettierrc.yml
  • files_exist - File found: CHANGELOG.md
  • files_exist - File found: CITATIONS.md
  • files_exist - File found: CODE_OF_CONDUCT.md
  • files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_exist - File found: nextflow_schema.json
  • files_exist - File found: nextflow.config
  • files_exist - File found: README.md
  • files_exist - File found: .github/.dockstore.yml
  • files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_exist - File found: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
  • files_exist - File found: .github/workflows/branch.yml
  • files_exist - File found: .github/workflows/nf-test.yml
  • files_exist - File found: .github/actions/get-shards/action.yml
  • files_exist - File found: .github/actions/nf-test/action.yml
  • files_exist - File found: .github/workflows/pr-comment.yml
  • files_exist - File found: .github/workflows/linting.yml
  • files_exist - File found: assets/email_template.html
  • files_exist - File found: assets/email_template.txt
  • files_exist - File found: assets/sendmail_template.txt
  • files_exist - File found: assets/nf-core-mag_logo_light.png
  • files_exist - File found: conf/modules.config
  • files_exist - File found: conf/test.config
  • files_exist - File found: conf/test_full.config
  • files_exist - File found: docs/CONTRIBUTING.md
  • files_exist - File found: docs/images/nf-core-mag_logo_light.png
  • files_exist - File found: docs/images/nf-core-mag_logo_dark.png
  • files_exist - File found: docs/output.md
  • files_exist - File found: docs/README.md
  • files_exist - File found: docs/README.md
  • files_exist - File found: docs/usage.md
  • files_exist - File found: nf-test.config
  • files_exist - File found: tests/default.nf.test
  • files_exist - File found: main.nf
  • files_exist - File found: assets/multiqc_config.yml
  • files_exist - File found: conf/base.config
  • files_exist - File found: conf/igenomes.config
  • files_exist - File found: conf/igenomes_ignored.config
  • files_exist - File found: .github/workflows/awstest.yml
  • files_exist - File found: .github/workflows/awsfulltest.yml
  • files_exist - File found: modules.json
  • files_exist - File found: ro-crate-metadata.json
  • files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
  • files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
  • files_exist - File not found check: .github/workflows/push_dockerhub.yml
  • files_exist - File not found check: .markdownlint.yml
  • files_exist - File not found check: .nf-core.yaml
  • files_exist - File not found check: .yamllint.yml
  • files_exist - File not found check: bin/markdown_to_html.r
  • files_exist - File not found check: conf/aws.config
  • files_exist - File not found check: docs/images/nf-core-mag_logo.png
  • files_exist - File not found check: lib/Checks.groovy
  • files_exist - File not found check: lib/Completion.groovy
  • files_exist - File not found check: lib/NfcoreTemplate.groovy
  • files_exist - File not found check: lib/Utils.groovy
  • files_exist - File not found check: lib/Workflow.groovy
  • files_exist - File not found check: lib/WorkflowMain.groovy
  • files_exist - File not found check: lib/WorkflowMag.groovy
  • files_exist - File not found check: parameters.settings.json
  • files_exist - File not found check: pipeline_template.yml
  • files_exist - File not found check: Singularity
  • files_exist - File not found check: lib/nfcore_external_java_deps.jar
  • files_exist - File not found check: .travis.yml
  • nf_test_content - 'tests/test_single_end.nf.test' contains outdir parameter
  • nf_test_content - 'tests/test_single_end.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/test_longreadonly.nf.test' contains outdir parameter
  • nf_test_content - 'tests/test_longreadonly.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/test_hybrid.nf.test' contains outdir parameter
  • nf_test_content - 'tests/test_hybrid.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/default.nf.test' contains outdir parameter
  • nf_test_content - 'tests/default.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/test_assembly_input.nf.test' contains outdir parameter
  • nf_test_content - 'tests/test_assembly_input.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/test_alternatives.nf.test' contains outdir parameter
  • nf_test_content - 'tests/test_alternatives.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/test_minimal.nf.test' contains outdir parameter
  • nf_test_content - 'tests/test_minimal.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/test_minimal.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/test_longreadonly_alternatives.nf.test' contains outdir parameter
  • nf_test_content - 'tests/test_longreadonly_alternatives.nf.test' snapshots a 'versions.yml' file
  • nf_test_content - 'tests/nextflow.config' contains modules_testdata_base_path
  • nf_test_content - 'tests/nextflow.config' contains pipelines_testdata_base_path
  • nf_test_content - 'nf-test.config' sets a testsDir
  • nf_test_content - 'nf-test.config' sets a workDir
  • nf_test_content - 'nf-test.config' sets a configFile
  • files_unchanged - .gitattributes matches the template
  • files_unchanged - .prettierrc.yml matches the template
  • files_unchanged - CODE_OF_CONDUCT.md matches the template
  • files_unchanged - LICENSE matches the template
  • files_unchanged - .github/.dockstore.yml matches the template
  • files_unchanged - .github/ISSUE_TEMPLATE/bug_report.yml matches the template
  • files_unchanged - .github/ISSUE_TEMPLATE/config.yml matches the template
  • files_unchanged - .github/ISSUE_TEMPLATE/feature_request.yml matches the template
  • files_unchanged - .github/workflows/pr-comment.yml matches the template
  • files_unchanged - assets/email_template.html matches the template
  • files_unchanged - assets/email_template.txt matches the template
  • files_unchanged - assets/sendmail_template.txt matches the template
  • files_unchanged - assets/nf-core-mag_logo_light.png matches the template
  • files_unchanged - docs/images/nf-core-mag_logo_light.png matches the template
  • files_unchanged - docs/images/nf-core-mag_logo_dark.png matches the template
  • files_unchanged - docs/README.md matches the template
  • files_unchanged - .gitignore matches the template
  • files_unchanged - .prettierignore matches the template
  • actions_nf_test - '.github/workflows/nf-test.yml' is triggered on expected events
  • actions_nf_test - '.github/workflows/nf-test.yml' checks minimum NF version
  • actions_awstest - '.github/workflows/awstest.yml' is triggered correctly
  • actions_awsfulltest - .github/workflows/awsfulltest.yml is triggered correctly
  • actions_awsfulltest - .github/workflows/awsfulltest.yml does not use -profile test
  • readme - README Nextflow minimum version badge matched config. Badge: 26.04.0, Config: 26.04.0
  • readme - README nf-core template version badge found.
  • readme - README Zenodo placeholder was replaced with DOI.
  • pipeline_todos - No TODO strings found
  • pipeline_if_empty_null - No ifEmpty(null) strings found
  • plugin_includes - No wrong validation plugin imports have been found
  • pipeline_name_conventions - Name adheres to nf-core convention
  • template_strings - Did not find any Jinja template strings (0 files)
  • schema_lint - Schema lint passed
  • schema_lint - Schema title + description lint passed
  • schema_lint - Input mimetype lint passed: 'text/csv'
  • system_exit - No System.exit calls found
  • actions_schema_validation - Workflow validation passed: awstest.yml
  • actions_schema_validation - Workflow validation passed: template-version-comment.yml
  • actions_schema_validation - Workflow validation passed: nf-test.yml
  • actions_schema_validation - Workflow validation passed: branch.yml
  • actions_schema_validation - Workflow validation passed: release-announcements.yml
  • actions_schema_validation - Workflow validation passed: linting.yml
  • actions_schema_validation - Workflow validation passed: labeler.yml
  • actions_schema_validation - Workflow validation passed: pr-comment.yml
  • actions_schema_validation - Workflow validation passed: download_pipeline.yml
  • actions_schema_validation - Workflow validation passed: awsfulltest.yml
  • actions_schema_validation - Workflow validation passed: clean-up.yml
  • actions_schema_validation - Workflow validation passed: fix-linting.yml
  • merge_markers - No merge markers found in pipeline files
  • modules_json - Only installed modules found in modules.json
  • multiqc_config - assets/multiqc_config.yml found and not ignored.
  • multiqc_config - assets/multiqc_config.yml contains report_section_order
  • multiqc_config - assets/multiqc_config.yml contains export_plots
  • multiqc_config - assets/multiqc_config.yml contains report_comment
  • multiqc_config - assets/multiqc_config.yml follows the ordering scheme of the minimally required plugins.
  • multiqc_config - assets/multiqc_config.yml contains a matching 'report_comment'.
  • multiqc_config - assets/multiqc_config.yml contains 'export_plots: true'.
  • modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'
  • local_component_structure - local subworkflows directory structure is correct 'subworkflows/local/TOOL/SUBTOOL'
  • base_config - conf/base.config found and not ignored.
  • base_config - ALE found in conf/base.config and Nextflow scripts.
  • base_config - BOWTIE2_ASSEMBLY_ALIGN found in conf/base.config and Nextflow scripts.
  • base_config - BOWTIE2_HOST_REMOVAL_ALIGN found in conf/base.config and Nextflow scripts.
  • base_config - BOWTIE2_HOST_REMOVAL_BUILD found in conf/base.config and Nextflow scripts.
  • base_config - BOWTIE2_PHIX_REMOVAL_ALIGN found in conf/base.config and Nextflow scripts.
  • base_config - BUSCO_BUSCO found in conf/base.config and Nextflow scripts.
  • base_config - CATPACK_BINS found in conf/base.config and Nextflow scripts.
  • base_config - CATPACK_CONTIGS found in conf/base.config and Nextflow scripts.
  • base_config - CATPACK_SUMMARISE_BINS found in conf/base.config and Nextflow scripts.
  • base_config - CHECKM2_PREDICT found in conf/base.config and Nextflow scripts.
  • base_config - CHECKM_LINEAGEWF found in conf/base.config and Nextflow scripts.
  • base_config - CHOPPER found in conf/base.config and Nextflow scripts.
  • base_config - COMEBIN_RUNCOMEBIN found in conf/base.config and Nextflow scripts.
  • base_config - CONCAT_BUSCO_TSV found in conf/base.config and Nextflow scripts.
  • base_config - CONCOCT_CONCOCT found in conf/base.config and Nextflow scripts.
  • base_config - DASTOOL_DASTOOL found in conf/base.config and Nextflow scripts.
  • base_config - FASTP found in conf/base.config and Nextflow scripts.
  • base_config - FILTLONG found in conf/base.config and Nextflow scripts.
  • base_config - FLYE found in conf/base.config and Nextflow scripts.
  • base_config - GTDBTK_CLASSIFYWF found in conf/base.config and Nextflow scripts.
  • base_config - MAG_DEPTHS found in conf/base.config and Nextflow scripts.
  • base_config - MAXBIN2 found in conf/base.config and Nextflow scripts.
  • base_config - MEGAHIT found in conf/base.config and Nextflow scripts.
  • base_config - METABAT2_METABAT2 found in conf/base.config and Nextflow scripts.
  • base_config - METABINNER_METABINNER found in conf/base.config and Nextflow scripts.
  • base_config - METAMDBG_ASM found in conf/base.config and Nextflow scripts.
  • base_config - METASPADES found in conf/base.config and Nextflow scripts.
  • base_config - METASPADESHYBRID found in conf/base.config and Nextflow scripts.
  • base_config - MINIMAP2_ASSEMBLY_ALIGN found in conf/base.config and Nextflow scripts.
  • base_config - MULTIQC found in conf/base.config and Nextflow scripts.
  • base_config - NANOLYSE found in conf/base.config and Nextflow scripts.
  • base_config - PORECHOP_ABI found in conf/base.config and Nextflow scripts.
  • base_config - DEEPMASED_FEATURES found in conf/base.config and Nextflow scripts.
  • base_config - DEEPMASED_PREDICT found in conf/base.config and Nextflow scripts.
  • base_config - PORECHOP_PORECHOP found in conf/base.config and Nextflow scripts.
  • base_config - PRODIGAL found in conf/base.config and Nextflow scripts.
  • base_config - PROKKA found in conf/base.config and Nextflow scripts.
  • base_config - PYPOLCA_RUN found in conf/base.config and Nextflow scripts.
  • base_config - QUAST_BINS found in conf/base.config and Nextflow scripts.
  • base_config - RENAME_PREDASTOOL found in conf/base.config and Nextflow scripts.
  • base_config - SEQKIT_STATS found in conf/base.config and Nextflow scripts.
  • modules_config - conf/modules.config found and not ignored.
  • modules_config - FASTQC_RAW found in conf/modules.config and Nextflow scripts.
  • modules_config - FASTP found in conf/modules.config and Nextflow scripts.
  • modules_config - TRIMMOMATIC found in conf/modules.config and Nextflow scripts.
  • modules_config - ADAPTERREMOVAL_PE found in conf/modules.config and Nextflow scripts.
  • modules_config - ADAPTERREMOVAL_SE found in conf/modules.config and Nextflow scripts.
  • modules_config - BOWTIE2_PHIX_REMOVAL_ALIGN found in conf/modules.config and Nextflow scripts.
  • modules_config - BOWTIE2_HOST_REMOVAL_ALIGN found in conf/modules.config and Nextflow scripts.
  • modules_config - FASTQC_TRIMMED found in conf/modules.config and Nextflow scripts.
  • modules_config - BBMAP_BBNORM found in conf/modules.config and Nextflow scripts.
  • modules_config - PORECHOP_PORECHOP found in conf/modules.config and Nextflow scripts.
  • modules_config - PORECHOP_ABI found in conf/modules.config and Nextflow scripts.
  • modules_config - FILTLONG found in conf/modules.config and Nextflow scripts.
  • modules_config - NANOQ found in conf/modules.config and Nextflow scripts.
  • modules_config - NANOLYSE found in conf/modules.config and Nextflow scripts.
  • modules_config - CHOPPER found in conf/modules.config and Nextflow scripts.
  • modules_config - NANOPLOT_RAW found in conf/modules.config and Nextflow scripts.
  • modules_config - NANOPLOT_FILTERED found in conf/modules.config and Nextflow scripts.
  • modules_config - MINIMAP2_HOST_INDEX found in conf/modules.config and Nextflow scripts.
  • modules_config - MINIMAP2_HOST_ALIGN found in conf/modules.config and Nextflow scripts.
  • modules_config - MINIMAP2_ASSEMBLY_INDEX found in conf/modules.config and Nextflow scripts.
  • modules_config - GUNZIP_SHORTREAD_ASSEMBLIES found in conf/modules.config and Nextflow scripts.
  • modules_config - MINIMAP2_ASSEMBLY_ALIGN found in conf/modules.config and Nextflow scripts.
  • modules_config - SAMTOOLS_HOSTREMOVED_UNMAPPED found in conf/modules.config and Nextflow scripts.
  • modules_config - SAMTOOLS_HOSTREMOVED_STATS found in conf/modules.config and Nextflow scripts.
  • modules_config - MEGAHIT found in conf/modules.config and Nextflow scripts.
  • modules_config - METASPADES found in conf/modules.config and Nextflow scripts.
  • modules_config - METASPADESHYBRID found in conf/modules.config and Nextflow scripts.
  • modules_config - FLYE found in conf/modules.config and Nextflow scripts.
  • modules_config - METAMDBG_ASM found in conf/modules.config and Nextflow scripts.
  • modules_config - QUAST found in conf/modules.config and Nextflow scripts.
  • modules_config - PYPOLCA_RUN found in conf/modules.config and Nextflow scripts.
  • modules_config - ALE found in conf/modules.config and Nextflow scripts.
  • modules_config - DEEPMASED_FEATURES found in conf/modules.config and Nextflow scripts.
  • modules_config - DEEPMASED_PREDICT found in conf/modules.config and Nextflow scripts.
  • modules_config - QUAST_BINS found in conf/modules.config and Nextflow scripts.
  • modules_config - GENOMAD_ENDTOEND found in conf/modules.config and Nextflow scripts.
  • modules_config - BOWTIE2_ASSEMBLY_ALIGN found in conf/modules.config and Nextflow scripts.
  • modules_config - MAG_DEPTHS_SUMMARY found in conf/modules.config and Nextflow scripts.
  • modules_config - BIN_SUMMARY found in conf/modules.config and Nextflow scripts.
  • modules_config - BUSCO_UNTAR found in conf/modules.config and Nextflow scripts.
  • modules_config - BUSCO_BUSCO found in conf/modules.config and Nextflow scripts.
  • modules_config - CHECKM_UNTAR found in conf/modules.config and Nextflow scripts.
  • modules_config - CHECKM_LINEAGEWF found in conf/modules.config and Nextflow scripts.
  • modules_config - CHECKM_QA found in conf/modules.config and Nextflow scripts.
  • modules_config - CONCAT_BUSCO_TSV found in conf/modules.config and Nextflow scripts.
  • modules_config - CHECKM2_DATABASEDOWNLOAD found in conf/modules.config and Nextflow scripts.
  • modules_config - CHECKM2_PREDICT found in conf/modules.config and Nextflow scripts.
  • modules_config - GALAH found in conf/modules.config and Nextflow scripts.
  • modules_config - GUNC_DOWNLOADDB found in conf/modules.config and Nextflow scripts.
  • modules_config - GUNC_RUN found in conf/modules.config and Nextflow scripts.
  • modules_config - GUNC_MERGECHECKM found in conf/modules.config and Nextflow scripts.
  • modules_config - CATPACK_PREPARE found in conf/modules.config and Nextflow scripts.
  • modules_config - CATPACK_BINS found in conf/modules.config and Nextflow scripts.
  • modules_config - CATPACK_ADDNAMES_BINS found in conf/modules.config and Nextflow scripts.
  • modules_config - CATPACK_SUMMARISE_BINS found in conf/modules.config and Nextflow scripts.
  • modules_config - CONCAT_UNBINS found in conf/modules.config and Nextflow scripts.
  • modules_config - CATPACK_UNBINS found in conf/modules.config and Nextflow scripts.
  • modules_config - CATPACK_ADDNAMES_UNBINS found in conf/modules.config and Nextflow scripts.
  • modules_config - CATPACK_SUMMARISE_UNBINS found in conf/modules.config and Nextflow scripts.
  • modules_config - GTDBTK_CLASSIFYWF found in conf/modules.config and Nextflow scripts.
  • modules_config - GTDBTK_SUMMARY found in conf/modules.config and Nextflow scripts.
  • modules_config - PROKKA found in conf/modules.config and Nextflow scripts.
  • modules_config - BAKTA_BAKTADBDOWNLOAD found in conf/modules.config and Nextflow scripts.
  • modules_config - BAKTA_BAKTA found in conf/modules.config and Nextflow scripts.
  • modules_config - PRODIGAL found in conf/modules.config and Nextflow scripts.
  • modules_config - FREEBAYES found in conf/modules.config and Nextflow scripts.
  • modules_config - BCFTOOLS_VIEW found in conf/modules.config and Nextflow scripts.
  • modules_config - BCFTOOLS_CONSENSUS found in conf/modules.config and Nextflow scripts.
  • modules_config - BCFTOOLS_INDEX found in conf/modules.config and Nextflow scripts.
  • modules_config - PYDAMAGE_ANALYZE found in conf/modules.config and Nextflow scripts.
  • modules_config - PYDAMAGE_FILTER found in conf/modules.config and Nextflow scripts.
  • modules_config - SUMMARISE_PYDAMAGEBINS found in conf/modules.config and Nextflow scripts.
  • modules_config - SAMTOOLS_FAIDX found in conf/modules.config and Nextflow scripts.
  • modules_config - METABAT2_JGISUMMARIZEBAMCONTIGDEPTHS_SHORTREAD found in conf/modules.config and Nextflow scripts.
  • modules_config - METABAT2_JGISUMMARIZEBAMCONTIGDEPTHS_LONGREAD found in conf/modules.config and Nextflow scripts.
  • modules_config - CONVERT_DEPTHS found in conf/modules.config and Nextflow scripts.
  • modules_config - METABAT2_METABAT2 found in conf/modules.config and Nextflow scripts.
  • modules_config - MAXBIN2 found in conf/modules.config and Nextflow scripts.
  • modules_config - CONCOCT_CUTUPFASTA found in conf/modules.config and Nextflow scripts.
  • modules_config - CONCOCT_ found in conf/modules.config and Nextflow scripts.
  • modules_config - COMEBIN_RUNCOMEBIN found in conf/modules.config and Nextflow scripts.
  • modules_config - METABINNER_ found in conf/modules.config and Nextflow scripts.
  • modules_config - METABINNER_METABINNER found in conf/modules.config and Nextflow scripts.
  • modules_config - METABINNER_BINS found in conf/modules.config and Nextflow scripts.
  • modules_config - SEMIBIN_SINGLEEASYBIN found in conf/modules.config and Nextflow scripts.
  • modules_config - SEQKIT_SEQ_MINCONTIGSIZE found in conf/modules.config and Nextflow scripts.
  • modules_config - SEQKIT_STATS found in conf/modules.config and Nextflow scripts.
  • modules_config - SPLIT_FASTA found in conf/modules.config and Nextflow scripts.
  • modules_config - DASTOOL_FASTATOCONTIG2BIN_TIARA found in conf/modules.config and Nextflow scripts.
  • modules_config - DASTOOL_FASTATOCONTIG2BIN found in conf/modules.config and Nextflow scripts.
  • modules_config - DASTOOL_DASTOOL found in conf/modules.config and Nextflow scripts.
  • modules_config - RENAME_POSTDASTOOL found in conf/modules.config and Nextflow scripts.
  • modules_config - TIARA_TIARA found in conf/modules.config and Nextflow scripts.
  • modules_config - TIARA_CLASSIFY found in conf/modules.config and Nextflow scripts.
  • modules_config - CONCAT_TIARA_TSV found in conf/modules.config and Nextflow scripts.
  • modules_config - MMSEQS_DATABASES found in conf/modules.config and Nextflow scripts.
  • modules_config - METAEUK_EASYPREDICT found in conf/modules.config and Nextflow scripts.
  • modules_config - MULTIQC found in conf/modules.config and Nextflow scripts.
  • modules_config - BIGMAG found in conf/modules.config and Nextflow scripts.
  • nfcore_yml - Repository type in .nf-core.yml is valid: pipeline
  • nfcore_yml - nf-core version in .nf-core.yml is set to the latest version: 4.2.2
  • rocrate_readme_sync - RO-Crate descriptions are in sync with README.md.
  • container_configs - conf/containers_conda_lock_files_amd64.config is up to date
  • container_configs - conf/containers_conda_lock_files_arm64.config is up to date
  • container_configs - conf/containers_docker_amd64.config is up to date
  • container_configs - conf/containers_docker_arm64.config is up to date
  • container_configs - conf/containers_singularity_https_amd64.config is up to date
  • container_configs - conf/containers_singularity_https_arm64.config is up to date
  • container_configs - conf/containers_singularity_oras_amd64.config is up to date
  • container_configs - conf/containers_singularity_oras_arm64.config is up to date

Run details

  • nf-core/tools version 4.2.2
  • Run at 2026-11-13 15:34:11

@prototaxites

Copy link
Copy Markdown
Contributor

Thank you for this! Please feel free to add yourself to the Credits section of the Readme, if you would like: https://github.com/nf-core/mag/blob/dev/README.md#credits

I have allowed the CI tests to run for this PR. You can skip this next time (and get permission to merge) by joining the nf-core GitHub organisation, see the documentation for more details: https://nf-co.re/docs/contributing/how-to-contribute#nf-core-slack-and-github

Once the tests pass, we can merge this fix.

@github-actions

Copy link
Copy Markdown

❌ nf-test failed with latest Nextflow version

Note

Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
Please check if the failure is expected with newer (edge-)releases of Nextflow or if it needs fixing.

  • ❌ docker | latest-everything | Shard 1/8

See the full run for details.

@prototaxites

Copy link
Copy Markdown
Contributor

Hi @Farhana-Anika - the tests have failed as the Tiara summary file has changed. Could you please update the failing test snapshot?

@Farhana-Anika

Farhana-Anika commented Nov 13, 2026 •

Copy link
Copy Markdown
Author

Thanks @prototaxites! I’ve updated the test_alternatives snapshot with the new tiara_summary.tsv md5 , and all the checks are passing now.

@prototaxites
prototaxites merged commit 23c0b3c into nf-core:dev Nov 15, 2026
21 checks passed
@Farhana-Anika Farhana-Anika mentioned this pull request Nov 16, 2026
1 of 11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants