fix: make CWD API typecheck clean and enforce CI - #26
Open
stevenjoezhang wants to merge 1 commit into
Open
Conversation
stevenjoezhang
marked this pull request as ready for review
July 29, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unknownxsswhiteListnamed export in both comment handlerspnpm typecheckcommandpackage.jsonso frozen installs workRoot cause
Cloudflare's
Response.json()correctly defaults tounknown, but the Telegram handlers consumed its result without a response type. Thexsspackage exposeswhiteListas a named export in its declarations, while the handlers accessed it as a property of the default callable export.The repository had no typecheck script or CI job, so these errors did not block deployment. The checked-in lockfile had also drifted from
cwd-api/package.json(aws4fetchwas missing and the Wrangler range was stale), which prevented a frozen CI install.Impact
cwd-apinow passes strict TypeScript checking. Runtime Telegram and XSS behavior is unchanged. Pull requests that touch the API will install from the frozen lockfile and run both typechecking and tests.Validation
pnpm install --frozen-lockfile --ignore-scriptspnpm typecheckpnpm test --run(4 files, 12 tests passed)wrangler deploy --dry-run --config wrangler.jsoncgit diff --check