fix: drop unused either dependency in minimald - #1081
Conversation
cargo-machete's hygiene check flagged `either` as declared in crates/minimald/Cargo.toml with no use in the crate, turning the nightly-tests hygiene job red. Searching crates/minimald confirms the crate never references the either crate: every `either`/`Either` occurrence is the English word inside a comment. Remove the orphaned declaration, matching prior unused-dep cleanups in minimald (chrono in #594, nix in #448). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Comment |
Fixes #1022
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKmXn2Q
cargo-machete flagged
eitheras declared in crates/minimald/Cargo.toml with no use in the crate, failing the nightly-tests hygiene job. A search of crates/minimald confirms the crate never references the either crate — everyeither/Eithermatch is the English word inside a comment — so the declaration is orphaned. Removed theeither.workspace = trueline and resynced Cargo.lock; either stays a transitive dependency, so only minimald's dependency entry changed (no version bumps). Matches prior minimald unused-dep cleanups (informed by #594, #448).Verification
cargo fmt --all --check — pass, no drift
cargo clippy --workspace --locked -- -D warnings — pass, 0 warnings
cargo build --workspace --locked — pass, Finished dev profile
cargo test --workspace --locked — pass, all suites ok (0 failed)
Note
Remove unused
eitherdependency fromminimaldRemoves the
eitherworkspace dependency from crates/minimald/Cargo.toml and updates the lockfile accordingly.Macroscope summarized 23fb694.