[worker:deadcode:rust] remove unused chrono dependency - #594
Merged
twitchyliquid64 merged 1 commit intoJun 29, 2026
Merged
Conversation
📝 WalkthroughWalkthroughRemoves the unused Remove unused chrono dependency
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
twitchyliquid64
approved these changes
Jun 29, 2026
twitchyliquid64
deleted the
chore/remove-unused-chrono-minimald-6bfac39126e6723d
branch
June 29, 2026 17:57
gominimal-aw-bot Bot
added a commit
that referenced
this pull request
Jul 29, 2026
cargo-machete's hygiene check flagged `either` as declared in crates/minimald/Cargo.toml with no use in the crate, turning the nightly-tests hygiene job red. Searching crates/minimald confirms the crate never references the either crate: every `either`/`Either` occurrence is the English word inside a comment. Remove the orphaned declaration, matching prior unused-dep cleanups in minimald (chrono in #594, nix in #448). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
twitchyliquid64
pushed a commit
that referenced
this pull request
Jul 29, 2026
cargo-machete's hygiene check flagged `either` as declared in crates/minimald/Cargo.toml with no use in the crate, turning the nightly-tests hygiene job red. Searching crates/minimald confirms the crate never references the either crate: every `either`/`Either` occurrence is the English word inside a comment. Remove the orphaned declaration, matching prior unused-dep cleanups in minimald (chrono in #594, nix in #448). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the
agent:deadcode:rustfinding in#593by removing the unusedchronodependency fromcrates/minimald/Cargo.toml.What changed
chrono.workspace = truefromcrates/minimald[dependencies]. A grep across the entireminimaldcrate for every chrono usage pattern (chrono::,Utc,DateTime,NaiveDate,Datelike,Timelike, ...) found no references — only the substring inside "synchronously"/"asynchronous" comments. The machete HIGH-confidence finding is accurate.Cargo.lock;chronostays as a transitive dependency of other crates, so onlyminimald's direct edge is removed.Candidates intentionally NOT changed
The issue also lists
prost,prost-types,tonic, andtonic-prost(remote-proto) as HIGH machetedepcandidates, with a triage note suggesting they move to[build-dependencies]. These are machete false positives:crates/remote-proto/src/lib.rspulls the generated protobuf/gRPC code in viainclude!(concat!(env!("OUT_DIR"), ...)), and that generated code references::prost::,::tonic::, and thetonic-prostcodec at runtime. machete cannot see those references because they live inOUT_DIR, not in the scanned.rssources. Moving the four crates to[build-dependencies](or removing them) would break compilation ofremote-proto, so they are left for human review.prost-build/tonic-prost-buildare already correctly in[build-dependencies](the issue notes no action needed).Verification
cargo build -p minimald --all-targets(from./target) passed (exit 0):minimaldand every crate it depends on compile cleanly withoutchrono. Becausechronowas a private dependency ofminimald, removing it cannot affect any other crate, so this targeted build fully covers the change.cargo build --workspace --all-targetsaborted withNo space left on device(os error 28) while linking unrelated test targets — a runner disk-exhaustion limitation, not a compile error from this change. After reclaiming the incremental-compile cache, the targeted build completed successfully..rsfiles were modified, socargo fmtis a no-op for this change.cargo fmt --all --check,cargo build --workspace --all-targets --locked,cargo clippy --workspace --all-targets --locked -- -D warnings,cargo test --workspace --all-targets --locked) before this PR opens.Closes #593
Summary by CodeRabbit