Skip to content

[worker:deadcode:rust] remove unused deps from minimal2 and minimald - #288

Merged
norrietaylor merged 1 commit into
mainfrom
chore/remove-unused-deps-268-7e65e8c575ab2211
Jun 2, 2026
Merged

[worker:deadcode:rust] remove unused deps from minimal2 and minimald#288
norrietaylor merged 1 commit into
mainfrom
chore/remove-unused-deps-268-7e65e8c575ab2211

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Drops 6 cargo-machete-confirmed unused dependencies identified in #268.

Crate Removed dep Reason
crates/minimal2 dirs No dirs:: usage in src/main.rs
crates/minimal2 futures No futures:: usage in src/main.rs
crates/minimal2 tokio-util No tokio_util:: usage in src/main.rs
crates/minimal2 tracing No tracing:: macro usage in src/main.rs (only tracing_subscriber used)
crates/minimald futures No futures:: usage in src/
crates/minimald tokio-util No tokio_util:: usage in src/

Closes #268

Verification

cargo fmt --all --check: no diff detected

cargo clippy --workspace --all-targets: Finished dev profile — 0 warnings, exit 0

cargo test --workspace --all-targets: 77 passed; 0 failed; 0 ignored (plus all other crate suites) — exit 0

cargo build --workspace --all-targets --locked: Finished dev profile — exit 0

Generated by Chore-issue worker agent (side-repo-ops operator) · ● 14.8M ·

Summary by CodeRabbit

  • Chores
    • Streamlined dependencies across project crates by removing unused packages, resulting in a lighter package footprint and simplified build configuration.

Removes 6 cargo-machete-confirmed unused dependencies:
- minimal2: dirs, futures, tokio-util, tracing
- minimald: futures, tokio-util

Closes #268

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes unused workspace dependencies from two crates. In minimal2, four dependencies (dirs, futures, tokio-util, tracing) are removed while keeping tokio. In minimald, two dependencies (futures, tokio-util) are removed, also retaining tokio.

Changes

Workspace Dependency Cleanup

Layer / File(s) Summary
Remove unused workspace dependencies
crates/minimal2/Cargo.toml, crates/minimald/Cargo.toml
Unused workspace dependencies (dirs, futures, tokio-util, tracing from minimal2; futures, tokio-util from minimald) are removed. Only tokio.workspace is retained in both crates, as it remains actively used.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • jtnkminimal
  • evanspearman
  • twitchyliquid64

Poem

🐰 Clutter clearing in the crates today,
Unused deps swept away!
Tokio stays, the rest may go,
Cargo's lighter now—let it flow!
Machete spoke, and we listened true. 🌾

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing unused dependencies from minimal2 and minimald crates.
Linked Issues check ✅ Passed All six dependencies identified in issue #268 have been successfully removed: minimal2 (dirs, futures, tokio-util, tracing) and minimald (futures, tokio-util).
Out of Scope Changes check ✅ Passed All changes are directly scoped to removing the six unused dependencies identified in issue #268; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@norrietaylor
norrietaylor merged commit 9454ac6 into main Jun 2, 2026
9 checks passed
@norrietaylor
norrietaylor deleted the chore/remove-unused-deps-268-7e65e8c575ab2211 branch June 2, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deadcode:rust] 6 dead-code dep candidates across 2 crates

1 participant