Skip to content

[worker:deadcode:rust] remove unused deps from minimal2 and minimald - #286

Closed
gominimal-aw-bot[bot] wants to merge 1 commit into
mainfrom
chore/remove-unused-deps-229-b72364347df28f9b
Closed

[worker:deadcode:rust] remove unused deps from minimal2 and minimald#286
gominimal-aw-bot[bot] wants to merge 1 commit into
mainfrom
chore/remove-unused-deps-229-b72364347df28f9b

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Drops 6 cargo-machete-confirmed unused dependencies identified in #229.

Crate Removed dep Reason
crates/minimal2 dirs No dirs:: usage in src/main.rs
crates/minimal2 futures No futures:: usage in src/main.rs
crates/minimal2 tokio-util No tokio_util:: usage in src/main.rs
crates/minimal2 tracing Only tracing_subscriber is used directly
crates/minimald futures No futures:: usage in any source file
crates/minimald tokio-util No tokio_util:: usage in any source file

Skipped candidates (remote-proto — 6 prost/tonic deps): false positives. src/lib.rs uses include!(concat!(env!("OUT_DIR"), "/_**.rs")) for prost-generated code; machete cannot see macro-include usage. prost-build and tonic-prost-build are build-dependencies explicitly invoked in build.rs.

Kept in minimald: dirs (used: dirs::state_dir(), dirs::home_dir(), dirs::cache_dir()), tracing (used: tracing::info!, tracing::warn!).

Closes #229

Verification

cargo fmt --all --check: no diff
cargo clippy --workspace --all-targets: Finished dev profile — no warnings
cargo test --workspace --all-targets: all tests passed
cargo build --workspace --all-targets --locked: Finished dev profile (locked, exit 0)

Generated by Chore-issue worker agent (side-repo-ops operator) · ● 20.1M ·

Summary by CodeRabbit

  • Chores
    • Cleaned up and removed unused internal dependencies to reduce project bloat and improve build efficiency.

Drops 6 machete-confirmed unused dependencies:
- minimal2: dirs, futures, tokio-util, tracing
- minimald: futures, tokio-util

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes unused workspace dependencies from two crates. minimal2 drops dirs, futures, tokio-util, and tracing while retaining tokio. minimald removes futures and tokio-util while keeping tokio. These changes address unused-dependency candidates flagged by cargo-machete analysis.

Changes

Workspace dependency cleanup

Layer / File(s) Summary
Remove unused dependencies from minimal2 and minimald
crates/minimal2/Cargo.toml, crates/minimald/Cargo.toml
Unused workspace dependencies futures and tokio-util are removed from both crates; minimal2 additionally removes dirs and tracing. Both crates retain tokio as an active dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • #229 — This PR directly addresses the unused-dependency candidates flagged by cargo-machete for minimal2 and minimald crates (dirs, futures, tokio-util, tracing).

Suggested reviewers

  • jtnkminimal
  • 0chroma
  • norrietaylor

Poem

🐰 A rabbit hops through dependency trees,
Pruning the branches with ease and with breeze,
Unused deps removed, the manifest stays lean,
tokio stands tall—the best ever seen! 🌳

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing unused dependencies from two crates (minimal2 and minimald) as flagged by cargo-machete.
Linked Issues check ✅ Passed The PR successfully addresses issue #229 by removing 4 unused dependencies from minimal2 (dirs, futures, tokio-util, tracing) and 2 from minimald (futures, tokio-util), with verification that builds, tests, and linting pass.
Out of Scope Changes check ✅ Passed All changes are within scope: only Cargo.toml files were modified to remove unused dependencies identified in issue #229; remote-proto crate dependencies were intentionally excluded per the PR notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@norrietaylor

Copy link
Copy Markdown
Member

closing as duplicate of #288

@norrietaylor
norrietaylor deleted the chore/remove-unused-deps-229-b72364347df28f9b branch July 23, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant