[worker:deadcode:rust] remove unused deps from minimal2 and minimald - #286
Closed
gominimal-aw-bot[bot] wants to merge 1 commit into
Closed
[worker:deadcode:rust] remove unused deps from minimal2 and minimald#286gominimal-aw-bot[bot] wants to merge 1 commit into
gominimal-aw-bot[bot] wants to merge 1 commit into
Conversation
Drops 6 machete-confirmed unused dependencies: - minimal2: dirs, futures, tokio-util, tracing - minimald: futures, tokio-util Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📝 WalkthroughWalkthroughThis PR removes unused workspace dependencies from two crates. ChangesWorkspace dependency cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Member
|
closing as duplicate of #288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops 6
cargo-machete-confirmed unused dependencies identified in #229.crates/minimal2dirsdirs::usage insrc/main.rscrates/minimal2futuresfutures::usage insrc/main.rscrates/minimal2tokio-utiltokio_util::usage insrc/main.rscrates/minimal2tracingtracing_subscriberis used directlycrates/minimaldfuturesfutures::usage in any source filecrates/minimaldtokio-utiltokio_util::usage in any source fileSkipped candidates (
remote-proto— 6 prost/tonic deps): false positives.src/lib.rsusesinclude!(concat!(env!("OUT_DIR"), "/_**.rs"))for prost-generated code; machete cannot see macro-include usage.prost-buildandtonic-prost-buildare build-dependencies explicitly invoked inbuild.rs.Kept in minimald:
dirs(used:dirs::state_dir(),dirs::home_dir(),dirs::cache_dir()),tracing(used:tracing::info!,tracing::warn!).Closes
#229Verification
cargo fmt --all --check: no diffcargo clippy --workspace --all-targets: Finisheddevprofile — no warningscargo test --workspace --all-targets: all tests passedcargo build --workspace --all-targets --locked: Finisheddevprofile (locked, exit 0)Summary by CodeRabbit