Skip to content

[worker:deadcode:rust] remove unused bytes and uuid deps from minimald - #308

Merged
norrietaylor merged 1 commit into
mainfrom
chore/remove-unused-minimald-deps-035399df0f38633f
Jun 3, 2026
Merged

[worker:deadcode:rust] remove unused bytes and uuid deps from minimald#308
norrietaylor merged 1 commit into
mainfrom
chore/remove-unused-minimald-deps-035399df0f38633f

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Jun 3, 2026 •
edited by norrietaylor
Loading

Copy link
Copy Markdown
Contributor

Issue #301 identified two unused dependencies in crates/minimald/Cargo.toml via cargo-machete:

  • bytes — no use bytes:: found anywhere in crates/minimald/src/
  • uuid — no use uuid:: found anywhere in crates/minimald/src/

This PR removes both entries from [dependencies] and regenerates Cargo.lock.

Verification

  • cargo fmt --all --check — no diff
  • cargo clippy --workspace --all-targets — Finished dev profile, 0 warnings
  • cargo test --workspace --all-targets — all tests passed, 0 failures
  • cargo build --workspace --all-targets --locked — exit 0

Closes #301

Generated by Chore-issue worker agent (side-repo-ops operator) · ● 40.5M · ◷

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to optimize build configuration.

@gominimal-aw-bot
fix(minimald): remove unused bytes and uuid deps
e3a78d3 
Remove bytes and uuid dependencies from crates/minimald/Cargo.toml.
Neither crate is imported anywhere in the minimald source tree.
Detected by cargo-machete.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes two unused workspace dependencies (bytes and uuid) from the minimald crate's Cargo.toml. The dependency declarations are deleted from the [dependencies] section, reducing configuration overhead and clarifying which dependencies are actively used.

Changes

Dependency cleanup

Layer / File(s) Summary
Remove unused workspace dependencies
crates/minimald/Cargo.toml		 Workspace dependency entries for bytes and uuid are removed from [dependencies], eliminating unused transitive declarations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

  • gominimal/minimal#288: Also removes unused workspace dependencies (futures and tokio-util) from crates/minimald/Cargo.toml as part of dependency cleanup.

Suggested reviewers

  • 0chroma
  • evanspearman
  • norrietaylor

Poem

🐰 Two deps that weren't in use,
Now freed from the crate's old noose,
Clean dependencies align,
Minimald's config shines so fine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing unused bytes and uuid dependencies from the minimald crate, which is exactly what the changeset does.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

Comment @coderabbitai help to get the list of available commands and usage tips.

@norrietaylor
norrietaylor merged commit c6be319 into main Jun 3, 2026
27 checks passed
@norrietaylor
norrietaylor deleted the chore/remove-unused-minimald-deps-035399df0f38633f branch June 3, 2026 18:56
@coderabbitai coderabbitai Bot mentioned this pull request Jun 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norrietaylor norrietaylor norrietaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[deadcode:rust] 2 dead-code candidates across 1 crate

1 participant

@norrietaylor