Skip to content

feat(stdlib): redistributable attr class - #861

Merged
bryan-minimal merged 2 commits into
mainfrom
feat/redistributable-attr-class
Jul 21, 2026
Merged

feat(stdlib): redistributable attr class#861
bryan-minimal merged 2 commits into
mainfrom
feat/redistributable-attr-class

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Adds the redistributable | Bool attr class (default-absent = true): declares whether a package's built artifacts may enter a shared binary cache. Set false when the upstream license or terms forbid redistribution — build infrastructure then neither uploads, indexes, nor seals the artifacts, and consumers build the package locally from the upstream source via the planner's existing index-miss fallback.

Schema + docs only — nothing in this repo reads it. Attrs are unhashed, so setting it causes zero rebuilds.

Supersedes #860.

🤖 Generated with Claude Code

Declares whether a package's built artifacts may enter a shared binary
cache. Absent means true. Set false when the upstream license or terms
forbid redistribution: build infrastructure then neither uploads, indexes,
nor seals the artifacts, and consumers build the package locally from the
upstream source (the planner's index-miss fallback — no CLI change).

Schema only; nothing reads it in this repo.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 052e52d7-1da8-4da3-8eb1-be93e2efb73d

📥 Commits

Reviewing files that changed from the base of the PR and between 187ca31 and 70699aa.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • crates/stdlib/Cargo.toml
  • crates/stdlib/minimal-ncl/attr_classes.ncl

Comment @coderabbitai help to get the list of available commands.

@twitchyliquid64

Copy link
Copy Markdown
Member

Also bump the version of the stdlib crate - then in pkgs we can set that to the minimum version in minimal.toml

@bryan-minimal

Copy link
Copy Markdown
Member Author

Done — stdlib bumped to 0.0.18 in the follow-up commit, and gominimal/pkgs#477 (draft) now sets minimum_version = "0.0.18" in minimal.toml alongside the attrs.

Lets catalogs that use the new attr declare minimum_version = "0.0.18" in
minimal.toml, so older toolchains get a clear update prompt instead of an
unknown-attribute decode error.
@bryan-minimal
bryan-minimal force-pushed the feat/redistributable-attr-class branch from 83ac5c2 to 70699aa Compare July 21, 2026 00:13
@bryan-minimal
bryan-minimal enabled auto-merge (squash) July 21, 2026 00:16
@bryan-minimal
bryan-minimal merged commit 4bfdcb0 into main Jul 21, 2026
27 of 28 checks passed
@bryan-minimal
bryan-minimal deleted the feat/redistributable-attr-class branch July 21, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants