attrs: mark android-sdk, claude-code, edgedelta non-redistributable - #477
Conversation
Their upstream terms do not permit redistribution of the built binaries, so build infrastructure must not publish them to the shared cache; consumers build them locally from the upstream source. Attrs are unhashed - no rebuilds. Requires the `redistributable` attr class (gominimal/minimal#861) in every evaluating toolchain before merge; attr validation is closed, so an older toolchain rejects unknown attrs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 17 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The redistributable attr class ships in stdlib 0.0.18; older toolchains would fail the catalog with an unknown-attribute error. The minimum turns that into a clear update prompt.
twitchyliquid64
left a comment
There was a problem hiding this comment.
Let’s wait a few days to push this one
ACK, I did a no-op commit and the test build went through fine on build-servers with the latest version of minimal and the new fields |
Sets
redistributable = falseon the three packages whose upstream terms do not permit redistribution of built binaries. Build infrastructure stops uploading/indexing/sealing them; consumers build locally from the upstream source. Attrs are unhashed — zero rebuilds.DRAFT — do not merge until the toolchain gate clears:
redistributableattr class) mergesMark ready-for-review once both are live.
🤖 Generated with Claude Code