MM-003 enforce the active Android app target - #5
Draft
himattm wants to merge 1 commit into
Draft
Conversation
Reproduction: a blank android_package allowed Minimap to capture and record whichever app happened to be in the foreground. Infer a standard Gradle debug application ID, report missing or ambiguous targets in doctor, and guard every device-backed command with the top resumed package. Refuse mismatches before capture or graph writes while retaining an explicit one-command override. Verified with Gradle inference contracts, missing and ambiguous doctor cases, wrong-app layout and whereami regressions, override coverage, cargo test --workspace, Clippy with warnings denied, formatting checks, and the minimap binary build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Infer the debug Android application ID from standard Gradle application modules, report missing or ambiguous package configuration in
doctor, and verify ADB's top resumed package before every device-backed command. An explicit--allow-package-mismatchoverride remains available.Why
A blank
android_packageallowed Minimap to capture whichever app happened to be foreground, polluting a repository's navigation graph with unrelated UI.Impact
Wrong-app captures are rejected before Android layout execution and before graph writes. Standard single-app Gradle projects initialize with the correct debug package automatically.
Validation
applicationIdplusapplicationIdSuffixinferenceStack
Depends on #4; base branch:
agent/mm-011-resolve-semantic-selector.