MM-008 make Android device selection explicit - #8
Draft
himattm wants to merge 1 commit into
Draft
Conversation
Reproduction: two ready devices passed layout preflight and failed later through ambiguous bare ADB calls, while successful single-device results omitted the serial, model, and API used. Make --device the primary selector with --serial compatibility, resolve android_device from the active profile, reject ambiguous defaults before capture, read stable ADB identity properties, and attach selection metadata to every guarded result and doctor check. Verified with no-device-to-single-device, two-device ambiguity, explicit and config selection contracts, legacy serial coverage, ADB identity units, a live API 36 GetGoing layout smoke test, cargo test --workspace, Clippy with warnings denied, formatting checks, and the minimap binary build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Make
--devicethe primary Android selector while retaining--serialcompatibility andANDROID_SERIAL. Add active-profileandroid_deviceresolution, reject ambiguous multi-device defaults before capture, query model/API through ADB, and attach serial, model, API level, and selection source to guarded results and doctor checks.Why
Two ready devices passed preflight and failed later through ambiguous bare ADB calls. Successful results also did not identify which emulator or phone produced them.
Impact
Multi-device runs require an intentional target, single-device defaults remain convenient, and every successful result is auditable to a concrete device.
Validation
--deviceselection--serialand environment coverageStack
Depends on #7; base branch:
agent/mm-005-lock-version-probe.