Aggregate policy partial evaluation diverges from runtime semantics u… - #51188
Open
vramik wants to merge 1 commit into
Open
Aggregate policy partial evaluation diverges from runtime semantics u…#51188vramik wants to merge 1 commit into
vramik wants to merge 1 commit into
Conversation
…nder FGAP v2 Closes keycloak#51143 Signed-off-by: vramik <vramik@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns aggregate-policy partial evaluation with FGAP v2 runtime semantics.
Changes:
- Applies negative child-policy logic before aggregate decisions.
- Fails closed for directly unsupported child providers.
- Adds authorization regression tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
AggregatePolicyProvider.java |
Updates partial aggregate evaluation semantics. |
UserResourceTypeFilteringTest.java |
Adds direct, list, count, and nested-policy tests. |
| // will invert our return value when policy.getLogic() == NEGATIVE, so we | ||
| // pre-compensate: return true for NEGATIVE (inverted to false by caller), | ||
| // false for POSITIVE (used as-is). Net result is always deny. | ||
| return Logic.NEGATIVE.equals(policy.getLogic()); |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test01_ldapOnlyGroupMappings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nder FGAP v2
Closes #51143