Skip to content

Aggregate policy partial evaluation diverges from runtime semantics u… #51188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vramik wants to merge 1 commit into
base: main
Choose a base branch
from
+114 −2
Open

Aggregate policy partial evaluation diverges from runtime semantics u… #51188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ...n/java/org/keycloak/authorization/policy/provider/aggregated/AggregatePolicyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.keycloak.models.RealmModel;
import org.keycloak.models.UserModel;
import org.keycloak.representations.idm.authorization.DecisionStrategy;
import org.keycloak.representations.idm.authorization.Logic;
import org.keycloak.representations.idm.authorization.ResourceType;

import org.jboss.logging.Logger;
Expand Down Expand Up @@ -120,11 +121,22 @@ public boolean evaluate(KeycloakSession session, Policy policy, UserModel subjec
PolicyProvider policyProvider = session.getProvider(AuthorizationProvider.class).getProvider(associatedPolicy.getType());

if (policyProvider instanceof PartialEvaluationPolicyProvider partialPolicyProvider) {
if (partialPolicyProvider.evaluate(session, associatedPolicy, subject)) {
boolean childResult = partialPolicyProvider.evaluate(session, associatedPolicy, subject);

if (Logic.NEGATIVE.equals(associatedPolicy.getLogic())) {
childResult = !childResult;
}

if (childResult) {
grants++;
}
} else {
return false;
// we cannot partially evaluate this child, so the aggregate
// must resolve to "deny" regardless of its own Logic. The caller (PartialEvaluator)
// will invert our return value when policy.getLogic() == NEGATIVE, so we
// pre-compensate: return true for NEGATIVE (inverted to false by caller),
// false for POSITIVE (used as-is). Net result is always deny.
return Logic.NEGATIVE.equals(policy.getLogic());
}
}

Expand Down
100 changes: 100 additions & 0 deletions ...base/src/test/java/org/keycloak/tests/admin/authz/fgap/UserResourceTypeFilteringTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;

import jakarta.ws.rs.ForbiddenException;
import jakarta.ws.rs.client.Client;
import jakarta.ws.rs.client.WebTarget;
import jakarta.ws.rs.core.GenericType;
Expand All @@ -47,6 +48,7 @@
import org.keycloak.representations.idm.authorization.GroupPolicyRepresentation;
import org.keycloak.representations.idm.authorization.Logic;
import org.keycloak.representations.idm.authorization.RolePolicyRepresentation;
import org.keycloak.representations.idm.authorization.TimePolicyRepresentation;
import org.keycloak.representations.idm.authorization.UserPolicyRepresentation;
import org.keycloak.testframework.annotations.InjectAdminClient;
import org.keycloak.testframework.annotations.InjectClient;
Expand Down Expand Up @@ -78,6 +80,7 @@
import static org.hamcrest.Matchers.not;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

@KeycloakIntegrationTest
Expand Down Expand Up @@ -203,6 +206,103 @@ public void testViewUserUsingRolePolicy() {
assertEquals(1, search.size());
}

@Test
public void testAggregatePolicyWithNegativeChildExcludesDeniedUsers() {
UserRepresentation myadmin = realm.admin().users().search("myadmin").get(0);
UserPolicyRepresentation denyMyAdmin = createUserPolicy(
Logic.NEGATIVE, realm, adminPermissionsClient, "Not My Admin User Policy", myadmin.getId());
AggregatePolicyRepresentation aggregatePolicy = createAggregatedPolicy(
adminPermissionsClient, "Positive Aggregate With Negative Child Policy",
Logic.POSITIVE, DecisionStrategy.AFFIRMATIVE, denyMyAdmin.getName());
Set<String> deniedUsers = Set.of("user-0", "user-15", "user-30");

createPermission(adminPermissionsClient, deniedUsers, usersType, Set.of(VIEW), aggregatePolicy);

UserRepresentation deniedUser = realm.admin().users().search("user-15").get(0);
assertThrows(ForbiddenException.class, () -> realmAdminClient.realm(realm.getName())
.users().get(deniedUser.getId()).toRepresentation());

List<UserRepresentation> search = realmAdminClient.realm(realm.getName())
.users().search(null, -1, -1);
assertThat(search, is(empty()));
assertThat(realmAdminClient.realm(realm.getName()).users().count("user-"), is(0));
}

@Test
public void testNegativeAggregateWithUnsupportedChildExcludesDeniedUser() {
TimePolicyRepresentation timePolicy = new TimePolicyRepresentation();
timePolicy.setName("Always Matching Time Policy");
try (Response response = adminPermissionsClient.authorization().policies().time()
.create(timePolicy)) {
assertThat(response.getStatus(), is(Response.Status.CREATED.getStatusCode()));
}

AggregatePolicyRepresentation aggregatePolicy = createAggregatedPolicy(
adminPermissionsClient, "Negative Aggregate With Time Child Policy",
Logic.NEGATIVE, DecisionStrategy.AFFIRMATIVE, timePolicy.getName());

UserRepresentation deniedUser = realm.admin().users().search("user-15").get(0);
createPermission(adminPermissionsClient, deniedUser.getId(), USERS_RESOURCE_TYPE, Set.of(VIEW), aggregatePolicy);

assertThrows(ForbiddenException.class, () -> realmAdminClient.realm(realm.getName())
.users().get(deniedUser.getId()).toRepresentation());

List<UserRepresentation> search = realmAdminClient.realm(realm.getName())
.users().search(deniedUser.getUsername(), 0, 10);
assertThat(search, is(empty()));
assertThat(realmAdminClient.realm(realm.getName()).users()
.count(null, null, null, deniedUser.getUsername()), is(0));
}

@Test
public void testAggregatePolicyUnanimousWithMixedChildren() {
UserRepresentation myadmin = realm.admin().users().search("myadmin").get(0);
UserPolicyRepresentation allowMyAdmin = createUserPolicy(
Logic.POSITIVE, realm, adminPermissionsClient, "Allow My Admin User Policy", myadmin.getId());
UserPolicyRepresentation denyMyAdmin = createUserPolicy(
Logic.NEGATIVE, realm, adminPermissionsClient, "Deny My Admin User Policy", myadmin.getId());
AggregatePolicyRepresentation aggregatePolicy = createAggregatedPolicy(
adminPermissionsClient, "Unanimous Aggregate With Mixed Children",
Logic.POSITIVE, DecisionStrategy.UNANIMOUS, allowMyAdmin.getName(), denyMyAdmin.getName());

UserRepresentation deniedUser = realm.admin().users().search("user-15").get(0);
createPermission(adminPermissionsClient, deniedUser.getId(), USERS_RESOURCE_TYPE, Set.of(VIEW), aggregatePolicy);

assertThrows(ForbiddenException.class, () -> realmAdminClient.realm(realm.getName())
.users().get(deniedUser.getId()).toRepresentation());

List<UserRepresentation> search = realmAdminClient.realm(realm.getName())
.users().search(deniedUser.getUsername(), 0, 10);
assertThat(search, is(empty()));
assertThat(realmAdminClient.realm(realm.getName()).users()
.count(null, null, null, deniedUser.getUsername()), is(0));
}

@Test
public void testNestedAggregateWithNegativeChild() {
UserRepresentation myadmin = realm.admin().users().search("myadmin").get(0);
UserPolicyRepresentation denyMyAdmin = createUserPolicy(
Logic.NEGATIVE, realm, adminPermissionsClient, "Not My Admin User Policy", myadmin.getId());
AggregatePolicyRepresentation innerAggregate = createAggregatedPolicy(
adminPermissionsClient, "Inner Aggregate With Negative Child",
Logic.POSITIVE, DecisionStrategy.AFFIRMATIVE, denyMyAdmin.getName());
AggregatePolicyRepresentation outerAggregate = createAggregatedPolicy(
adminPermissionsClient, "Outer Aggregate Wrapping Inner",
Logic.POSITIVE, DecisionStrategy.AFFIRMATIVE, innerAggregate.getName());

UserRepresentation deniedUser = realm.admin().users().search("user-15").get(0);
createPermission(adminPermissionsClient, deniedUser.getId(), USERS_RESOURCE_TYPE, Set.of(VIEW), outerAggregate);

assertThrows(ForbiddenException.class, () -> realmAdminClient.realm(realm.getName())
.users().get(deniedUser.getId()).toRepresentation());

List<UserRepresentation> search = realmAdminClient.realm(realm.getName())
.users().search(deniedUser.getUsername(), 0, 10);
assertThat(search, is(empty()));
assertThat(realmAdminClient.realm(realm.getName()).users()
.count(null, null, null, deniedUser.getUsername()), is(0));
}

@Test
public void testViewUserUsingMultiplePolicies() {
List<UserRepresentation> search = realmAdminClient.realm(realm.getName()).users().search(null, 0, 10);
Expand Down
Loading