Repository navigation
refactor(compile): lay out blocks through graph.Order - #349
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
layout re-implemented graph.Order's iterative reverse-postorder DFS to change one thing: a loop branch visits its staying successor last. It now precomputes those successor lists and walks them with graph.Order, so one DFS serves every reverse-postorder caller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
siyul-park
force-pushed
the
refactor/layout-order
branch
from
November 19, 2026 13:25
2804191 to
e0893e5
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compile.(*lowering).layoutre-implementedgraph.Order's iterative reverse-postorder DFS to change one thing: a two-way loop branch visits its loop-staying successor last, so it falls through. It now precomputes those successor lists once (no per-step allocation) and walks them withgraph.Orderthrough a smalllaidview. One DFS serves every reverse-postorder caller. −13 lines.Fourth of the pipeline structural cleanups (after #346, #347, #348).
Evidence
TestLowerred, so the contract stays pinned.make benchmark-diff base=5a3ef12(interleaved, n=6): geomean +0.14%; no significant change on anyjitrow (significant rows arethreaded/optimized, which this PR cannot reach).Test plan
go test ./internal/jit/... ./interpmake checkgit diff --check🤖 Generated with Claude Code