Repository navigation
refactor(compile): decide signature facts once and narrow Lower and NewCode - #350
Merged
Merged
Conversation
…ewCode build recomputed the register-convention arguments and results and the completion count for jit.NewCode, while Lower had already decided the same values for the Layout it hands Prologue. Lower now records them in jit.Assembly from that one Layout, and NewCode takes them from there: NewCode(address, ip, osr, tier, a). Lower and newLowering took five values that are Unit fields or derived from them (Function, Module.Objects, Address, OSR, and count from Tier); they now take the Unit: Lower(f, u, m). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildrecomputed the register-convention arguments (gated on!OSR), results, and the completion count forjit.NewCode, whileLowerhad already decided the same values for theLayoutit handsMachine.Prologue/Enter.Lowernow keeps that oneLayoutand records itsArguments/Registerspluscompletion(f)injit.Assembly;jit.NewCode(address, ip, osr, tier, a)takes them from there (was 8 positional args).Lower/newLoweringtook five values that areUnitfields or derived from them (Function,Module.Objects,Address,OSR, andcount = Tier == Baseline && !OSR); they now take theUnit:Lower(f, u, m).compile.Unitfields instead of positional booleans.Fifth of the pipeline structural cleanups (after #346–#349).
Evidence
make benchmark-diff base=af77c18(interleaved, n=6): geomean +0.04%; the only significantjitrow is xorshift-i64 +1.08% (p=0.039), whose generated code this PR leaves byte-identical — noise.Test plan
go test ./internal/... ./interp ./optimizemake checkgit diff --check🤖 Generated with Claude Code
Summary by CodeRabbit