Repository navigation
Conversation
|
@ruchikajha95 - I found that some items were missing: The field numbers for Protostream should be explicitly numbered to care for eventually removed fields. Also the new Protostream object wasn't registered in the marshaller, and due to that I saw exeception once I created multiple nodes. Thanks! |
9fb2cd8 to
a733f3f
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the clock-skew sample serialization changes.
No open issues 🎉
What changed in this PR
This PR addresses #55238 by registering clock-skew samples in Keycloak’s ProtoStream schema so they can be serialized between cluster nodes.
Changes:
- Add
ClockSkewTimestampSampletoKeycloakModelSchema. - Assign explicit protobuf field numbers to stabilize the sample’s wire format.
| File | Description |
|---|---|
model/infinispan/src/main/java/org/keycloak/marshalling/KeycloakModelSchema.java |
Include clock-skew samples in the generated marshalling schema. |
model/infinispan/src/main/java/org/keycloak/cluster/infinispan/ClockSkewTimestampSample.java |
Explicitly number the node-name and timestamp fields. |
Review effort: Balanced
ruchikajha95
left a comment
There was a problem hiding this comment.
LGTM . Thanks @ahus1 for the PR.
Closes keycloak#55238 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
a733f3f to
df3331a
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The local-cache test passes even without the registration, so a production-schema ProtoStream round-trip regression test is needed to verify that both ClockSkewTimestampSample components survive serialization.
1 open issue
Review effort: Balanced
ruchikajha95
left a comment
There was a problem hiding this comment.
Approving again after rebase. Thanks @ahus1
Closes #55238
The class from 69527b1 is annotated with
@ProtoTypeIdbut was never added toKeycloakModelSchema, so it was missing from the generated protobuf schema.Decisions and assumptions:
@ProtoField. They match the numbers the processor derived from the component order, so the wire format is unchanged.