Isolated Processes 9: Repair ProcessReader API#188
Merged
Conversation
Collaborator
Author
|
@afranchuk I also can't add you as a reviewer for whatever reason, but... Tada! 🎉 |
marti4d
force-pushed
the
isolated_process/09-fix-process-reader
branch
5 times, most recently
from
June 25, 2026 14:34
9467308 to
c65f61d
Compare
marti4d
force-pushed
the
isolated_process/09-fix-process-reader
branch
from
June 25, 2026 15:55
c65f61d to
92f580a
Compare
Jake-Shadle
removed their request for review
June 25, 2026 17:58
afranchuk
suggested changes
Jul 6, 2026
afranchuk
left a comment
Contributor
There was a problem hiding this comment.
This looks great! Let's rename or broaden the process-reader crate.
Collaborator
Author
|
@gabrielesvelto This should be a pretty quick review, since Alex has already approved it :) |
afranchuk
approved these changes
Jul 6, 2026
Contributor
|
Looking at this now. I assume it obsoletes PR #187 right? |
gabrielesvelto
approved these changes
Jul 7, 2026
gabrielesvelto
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks to both of you
marti4d
force-pushed
the
isolated_process/09-fix-process-reader
branch
from
July 7, 2026 13:40
f8b35ba to
eee48b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.