Restore the linux ProcessReader API#187
Open
afranchuk wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Note that it would be better to move the ProcessReader stuff into a separate crate, however until we have time to do that (which will take a little effort as there is definitely some tangling in other code), this exposes what we need. |
Contributor
Author
|
@marti4d I can't add you as a reviewer, but take a look. |
Contributor
|
Ah yes, this was my mistake, but there's an extra angle to this: not only we need the interface but we need it to work with isolated processes too. If that's not possible we need to fold the annotation-reading code into the regular dumping process (potentially as a feature since we'd be the only ones interested in it). |
Contributor
|
Adding Chris as a reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API was added in #168 and is present in 0.12, however it was lost in #181. It is necessary for Bug 2009827 - Use minidump-writer in place of the in-tree process_reader crate.