Bug 1831094: Add a process reader and module reader for each platform#168
Open
afranchuk wants to merge 2 commits intorust-minidump:mainfrom
Open
Bug 1831094: Add a process reader and module reader for each platform#168afranchuk wants to merge 2 commits intorust-minidump:mainfrom
afranchuk wants to merge 2 commits intorust-minidump:mainfrom
Conversation
This better reflects what the type represents. This also absorbs the `ProcessReader` type, which was poorly named as well, and adds a variant which takes a MemReader by reference.
32c1c29 to
af7d19a
Compare
This renames the linux `MemReader` to be the `ProcessReader`, and adds new implementations for mac and windows. The `ModuleReader`s have the minimum features needed; they can be filled out more in the future.
af7d19a to
72f80ad
Compare
Contributor
|
Sorry I've been holding off reviewing this one but I was waiting for PR #167 first given the changes there are more urgent and both PRs end up touching the same functionality. |
Contributor
Author
|
Sounds good, I'll rebase once that is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges features from the firefox process_reader crate for bug 1831094, in a step toward using
minidump-writerto read crash annotations on its own.