Skip to content

Import dependencies from VCPKG by default on Windows. - #869

Open
emptyVoid wants to merge 1 commit into
OpenApoc:masterfrom
emptyVoid:vcpkg-dependencies
Open

emptyVoid wants to merge 1 commit into
OpenApoc:masterfrom
emptyVoid:vcpkg-dependencies

Conversation

@emptyVoid

Copy link
Copy Markdown
Contributor

Here's a proposal to import uncustomised dependency libraries from VCPKG instead of building them from sources. Importing is enabled by default on Windows and could be enabled via USE_VCPKG_* options on other platforms, the same options could be used to disable importing on Windows.

Resolves #866.

@JonnyH

JonnyH commented May 13, 2020

Copy link
Copy Markdown
Collaborator

I'm unsure if this is actually needed going forward - we need the sources for other platforms already, and I personally like having sources locally to aid debugging into libraries - maybe there's something wrong with my setup but it doesn't seem to do source-level debugging with vcpkg-imported libraries.

@emptyVoid

Copy link
Copy Markdown
Contributor Author

Have you tried updating vcpkg?
I've just tested stepping into pugi::xml_document::load_file -- works as expected.

@emptyVoid
emptyVoid force-pushed the vcpkg-dependencies branch from 8996c0c to 112f89a Compare May 13, 2020 20:10
@FilmBoy84 FilmBoy84 added WIP Work In Progress. This is not a complete feature/fix. Check it out, maybe you have something to add? STALLED Work In Progress but for whatever reason, nothing's been done for a while. New coders may be needed! labels Mar 26, 2023

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

STALLED Work In Progress but for whatever reason, nothing's been done for a while. New coders may be needed! WIP Work In Progress. This is not a complete feature/fix. Check it out, maybe you have something to add?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Are dependencies required to be built from sources?

3 participants