Repository navigation
net: follow up wizard and doctor detection - #157
Merged
Merged
Conversation
Cd1s
force-pushed
the
fix/151-doctor-wizard
branch
from
October 18, 2026 00:02
a7383bc to
0ff0c8e
Compare
This was referenced Oct 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mr doctorfor PPPoE WANs without an address, with a clear DHCP modem mode hint and detect action. Positive and negative probe results both obey the 10-minute per-WAN cooldown; WAN recovery clears stale outage state.require_public_ipgive-up state as a WAN risk only while the guard remains enabled; stale state is ignored when the option is disabled.dev.jslease edit flow in CI.Why
Fresh-environment runs need to explain a PPPoE line that has been changed to routed DHCP, and the overview must agree with the bounded public-IP guard after it gives up. Both positive and negative DHCP probe results are cached, so repeated doctor calls do not broadcast repeatedly. The wizard and lease tests exercise production handlers and UI code rather than copied logic.
The WiFi wizard's empty regulatory-country behavior is documented as a follow-up in #161: the current flow preserves an empty country and lets the user configure it later. This PR references #151 while that separate UX decision is resolved.
Verification
cd mr && gofmt -l . && go vet ./...cd mr && go test -count=1 ./...node tools/mock/lease-sequence.test.jsMR_LAB_TREE=/root/build/mr-s1 tools/lab/lab.sh run 1 05-isp-switch-live— TAP 1..6, all six checksok; check 5 matched the doctor DHCP OFFER hintsh tools/ci.sh—ALL CHECKS PASSEDRefs #151