Skip to content

net: follow up wizard and doctor detection - #157

Merged
Cd1s merged 2 commits into
mainfrom
fix/151-doctor-wizard
Oct 18, 2026
Merged

Cd1s merged 2 commits into
mainfrom
fix/151-doctor-wizard

Conversation

@Cd1s

@Cd1s Cd1s commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

What

  • Add a cached and throttled DHCP OFFER probe to mr doctor for PPPoE WANs without an address, with a clear DHCP modem mode hint and detect action. Positive and negative probe results both obey the 10-minute per-WAN cooldown; WAN recovery clears stale outage state.
  • Surface require_public_ip give-up state as a WAN risk only while the guard remains enabled; stale state is ignored when the option is disabled.
  • Add a real API-handler first-run wizard regression test and run the real dev.js lease edit flow in CI.
  • Tune WAN detection retries/packet flags, update doctor/net documentation, and make the integration-test signal traps exit after cleanup.

Why

Fresh-environment runs need to explain a PPPoE line that has been changed to routed DHCP, and the overview must agree with the bounded public-IP guard after it gives up. Both positive and negative DHCP probe results are cached, so repeated doctor calls do not broadcast repeatedly. The wizard and lease tests exercise production handlers and UI code rather than copied logic.

The WiFi wizard's empty regulatory-country behavior is documented as a follow-up in #161: the current flow preserves an empty country and lets the user configure it later. This PR references #151 while that separate UX decision is resolved.

Verification

  • cd mr && gofmt -l . && go vet ./...
  • cd mr && go test -count=1 ./...
  • node tools/mock/lease-sequence.test.js
  • MR_LAB_TREE=/root/build/mr-s1 tools/lab/lab.sh run 1 05-isp-switch-live — TAP 1..6, all six checks ok; check 5 matched the doctor DHCP OFFER hint
  • sh tools/ci.sh — ALL CHECKS PASSED

Refs #151

@Cd1s
Cd1s force-pushed the fix/151-doctor-wizard branch from a7383bc to 0ff0c8e Compare October 18, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant