Repository navigation
net: require WiFi country in first-run wizard - #166
Merged
Merged
Conversation
Cd1s
force-pushed
the
fix/161-wifi-country
branch
from
October 18, 2026 07:57
6b69c23 to
f8ba1c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the first-run wizard enables WiFi, it now requires a confirmed regulatory country code. The wizard suggests a code from the browser locale or time zone and requires an explicit confirmation; when no suggestion is available, it requires a country selection. Backend WiFi validation enforces the same rule for every config with enabled radios. The WiFi module docs and English UI dictionary are updated, with a 360px mock screenshot included.
Why
An empty country code can leave hostapd without a regulatory domain and silently restrict 5 GHz channels. The wizard now makes the compliance choice visible and prevents an empty country from reaching apply.
Verification
cd mr && gofmt -l . && go vet ./...cd mr && go test -count=1 ./...python3 tools/i18n.py check;node --check rootfs/www/ui/core.jssh tools/ci.sh—ALL CHECKS PASSEDwizard-wifi-360.png#151 remaining review items were already completed by #157 (API wizard regression, WAN detection tuning and DHCP OFFER doctor hint); this PR resolves its WiFi-country follow-up.
Closes #161
Refs #151