Add Japanese language to language switcher - #5024
Open
AokiMasaru wants to merge 1 commit into
Open
AokiMasaru wants to merge 1 commit into
AokiMasaru wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Japanese language switcher support
The Japanese translation (
po/ja_JP.po) has existed in the repositoryfor some time, but Japanese was not yet registered as a selectable
language in the in-game language switcher / options menu.
This PR follows the same pattern as the existing Serbian language
addition (commit 67e7d0c) to register Japanese as a selectable UI
language.
Changes
lib/framework/i18n.cpp: AddLANG_NAME_JAPANESEand registerja_JPin both the Windows and Unix language mapssrc/titleui/options/interfaceoptions.cpp: Mapja_JPtoflag-JP.pngin the language icon mapdata/base/images/flags/flag-JP.png: New Japan flag icon(generated via
tools/image/flags.sh, sourced from FlagKit)data/base/images/flags.img: Register the new flag imagetools/image/flags.sh: AddJPto the flag generation listTesting
(Options → Interface → Language) with the correct flag icon, and
switching to/from Japanese works correctly alongside other languages