Skip to content

[Outlaw] Outlaw Rogue support for Midnight 12.0.7 - #8001

Open
moonrose-wow wants to merge 10 commits into
WoWAnalyzer:midnightfrom
moonrose-wow:outlaw-midnight-analyzer
Open

moonrose-wow wants to merge 10 commits into
WoWAnalyzer:midnightfrom
moonrose-wow:outlaw-midnight-analyzer

Conversation

@moonrose-wow

Copy link
Copy Markdown

Description

This is a rough MVP of Outlaw Rogue support for Midnight.
I have more local commits to complete this work, this is the first stepping stone.

  • Corrected Midnight spell and talent values, Energy maximum and regeneration
  • Fixed baseline bugs: Between the Eyes cooldown tracking, Restless Blades mutating
    a shared event, listeners not scoped to the selected player
  • Replaced the two legacy War Within priority lists with one adapted from the
    Midnight SimulationCraft priority
  • Targets the Trickster hero tree; Fatebound logs get a warning banner

Testing

  • Test report URL: /report/NFCDkVgfxjamd2Bh/19-Mythic++Magisters'+Terrace+-+Kill+(31:13)/3-Tomelvis/standard
  • Screenshot(s):
pr1-APL pr1-core-rotation pr1-combo-points

I left out untouched sections, that have not been updated as of this commit yet.

moonrose-wow and others added 10 commits August 9, 2026 18:27
Wire up the CombatLogParser entry point and drop Outlaw from the tsconfig
exclude list, so the spec is typechecked from here on. Rename the Roll the
Bones buff list to ROLL_THE_BONES_STAGE_AURAS, keeping the old name as an
alias while the legacy rotations still reference it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
From the in-game tooltips: Killing Spree is a 3 minute cooldown rather
than 90 seconds, and Adrenaline Rush is off the GCD.

Register the Blade Rush buff rather than its talent id, add Between the
Eyes and Thistle Tea, and drop the Shadow Dance and Riposte auras Outlaw
cannot get. Bump patchCompatibility to 12.0.7.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
In Midnight, Adrenaline Rush grants +50 maximum Energy and +75%
regeneration. Combat Potency is a talent that gives a passive +16%
regen that is now modelled.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Add a rollTheBonesStage helper and named stage thresholds, so the combo
point tracker asks for the active stage instead of testing three auras by
hand. Each aura is a superset of the one below, so only the highest one
matters and counting them always yields 1. Roll the Bones casts record
the stage they landed on for the same reason.

Extract SimC's variable.finish_condition into a single
finisherComboPointThreshold definition, and move the remaining callers off
the ROLL_THE_BONES_BUFFS alias onto ROLL_THE_BONES_STAGE_AURAS.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The beginCooldown override suppressed Between the Eyes' cooldown entirely,
justified by Crack Shot, a talent that no longer exists in Midnight.
Abilities.tsx already declares the 45 second cooldown, so isAvailable() was
unconditionally true and every "is Between the Eyes ready" check silently
collapsed. Restless Blades mutated the shared SpendResourceEvent with +=, so
every later listener saw an inflated resourceChange, Supercharger assumed 2
combo points rather than reading its rank, and Blade Rush skipped
energyAmount === 0, exactly the starved state it exists to report.

BuilderUse listened to every rogue in the group, logged to the console, and
judged builders against combo point thresholds that ignored Opportunity
stacks and Fan the Hammer's rank. It now follows the SimulationCraft builder
list, names the reason each builder was wasted, and reports Opportunity
stacks that expired unspent.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Outlaw analysis targets the Trickster hero tree, and Fatebound is not
maintained. Gate the guide on Unseen Blade, Trickster's keystone, so a rogue
on any other hero tree is told the rotational checks will not match their
build instead of reading them as advice.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Adapt the SimulationCraft Midnight priority (rogue_outlaw.simc), replacing the
two talent-switched War Within rotations with a single list. Preparation and
the Deft Maneuvers builder are positive-only, because a log cannot fairly
demand a held cooldown or a target count estimated from recent damage, and
Killing Spree carries no hand-written negations of the rules above it, since
the ordered scan already handles precedence.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Spread defaultExplainers rather than replacing them, which keeps
defaultClaimFilter's 40% violation gate and the wall of low-value problems it
holds back on a strong parse. Two Outlaw notes are additive: combo point waste
on a low-CP finisher, and Adrenaline Rush cast at high combo points. A
Dispatch at the Between the Eyes threshold is no longer blamed on a missed
Killing Spree.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Add the contributor entry and list Moonrose alongside Silverkage on the Outlaw
spec config.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The user-visible changes to this point: the Midnight spell and talent
values, the Adrenaline Rush Energy ceiling, the Between the Eyes cooldown
fix, the Trickster build warning, and the Midnight priority list with its
shared problem detection.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@emallson

Copy link
Copy Markdown
Collaborator

please coordinate with @Texleretour since you're both working on Outlaw PRs and there appears to be quite a bit of overlap between this and #8000

@moonrose-wow

Copy link
Copy Markdown
Author

@Texleretour The best would be that you get your changes merged and I'll rebase my changes above yours and update this PR.

I'll probaby change it altogether to make everything compatible with 12.1 directly and not go through the intermediary step of making it work for 12.0.7

@toofan-wow

Copy link
Copy Markdown

@moonrose-wow this should be unblocked. When you get a chance, could you please rebase and get this PR ready. thnx

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants