Skip to content

etcd_docker 2: Add a docker based etcdintegration package - #4146

Closed
andrewmains12 wants to merge 1 commit into
uber/20220830-grpc_updatefrom
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e4e80f1d
Closed

etcd_docker 2: Add a docker based etcdintegration package#4146
andrewmains12 wants to merge 1 commit into
uber/20220830-grpc_updatefrom
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e4e80f1d

Conversation

@andrewmains12

@andrewmains12 andrewmains12 commented Aug 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR 2 for #4144

High level approach is as described in #4144 . This PR adds:

  • Functions to spin up a 1 node etcd cluster using docker (in dockerexternal)
  • A drop in replacement for the etcd/integration package using dockerexternal

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Aug 29, 2022
Merged
Merged
Closed
Merged
Merged
@andrewmains12
andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/e4e80f1d branch from 7e5e58c to d2efdf1 Compare August 30, 2022 14:44
@andrewmains12 andrewmains12 changed the title Add a docker based etcdintegration package etcd_docker 2: Add a docker based etcdintegration package Aug 30, 2022
@andrewmains12
andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa branch 2 times, most recently from 8d19f7d to 839899d Compare August 30, 2022 15:16
@andrewmains12
andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/e4e80f1d branch from d2efdf1 to 508602f Compare August 30, 2022 15:16
justinjc
justinjc reviewed Aug 30, 2022
View reviewed changes
Comment thread docker-compose.yml
Comment thread src/cluster/client/etcd/types.go Outdated
Comment thread src/cluster/client/etcd/config.go Outdated
Comment thread src/integration/resources/docker/dockerexternal/etcdintegration/bridge/bridge.go
Comment thread src/integration/resources/docker/dockerexternal/etcdintegration/cluster.go Outdated
@andrewmains12
andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/e4e80f1d branch 5 times, most recently from 41f04db to 866cd06 Compare August 30, 2022 22:57
Base automatically changed from pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa to uber/20220830-grpc_update August 31, 2022 14:38
@andrewmains12
etcd_docker 2: Add a docker based etcdintegration package
6c4a00a 
PR 2 for #4144

High level approach is as described in #4144 . This PR adds:

- Functions to spin up a 1 node etcd cluster using docker (in `dockerexternal`)
- A drop in replacement for the etcd/integration package using `dockerexternal`

commit-id:e4e80f1d
@andrewmains12
andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/e4e80f1d branch from 866cd06 to 6c4a00a Compare August 31, 2022 14:38
@andrewmains12

andrewmains12 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor Author

✓ Commit merged in pull request #4147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinjc justinjc justinjc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewmains12 @justinjc