etcd_docker 4: Incorporate docker based etcd into Go integration tests - #4148
Merged
andrewmains12 merged 1 commit intoSep 2, 2022
Conversation
This was referenced Aug 29, 2022
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
August 30, 2022 14:44
7b49976 to
8445afb
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
3 times, most recently
from
August 30, 2022 16:52
50a14e2 to
77ca046
Compare
justinjc
reviewed
Aug 30, 2022
| # Load rules once and periodically evaluate them according to the global 'evaluation_interval'. | ||
| rule_files: | ||
| # - "first_rules.yml" | ||
| # - "second_rules.yml" |
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
2 times, most recently
from
August 30, 2022 17:49
d7b617c to
2a63e79
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
from
August 30, 2022 21:28
4b364dd to
26bc538
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
3 times, most recently
from
August 30, 2022 22:01
6910f1e to
c8b6a12
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
from
August 30, 2022 22:13
0fbfcc1 to
bd47234
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
August 30, 2022 22:13
c8b6a12 to
0580883
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
from
August 30, 2022 22:57
bd47234 to
c855a4f
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
2 times, most recently
from
August 31, 2022 14:38
b47a381 to
9398782
Compare
Base automatically changed from
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
to
uber/20220830-grpc_update
August 31, 2022 15:18
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
August 31, 2022 15:18
9398782 to
e3a4a1a
Compare
justinjc
approved these changes
Aug 31, 2022
| // representing component configs. | ||
| func NewClusterConfigsFromYAML(dbnodeYaml string, coordYaml string, aggYaml string) (ClusterConfigs, error) { | ||
| var dbCfg dbcfg.Configuration | ||
| // "db": |
Collaborator
There was a problem hiding this comment.
Is this comment block still relevant?
andrewmains12
deleted the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
September 2, 2022 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 4 for #4144
High level approach is as described in #4144 .
This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.
commit-id:3ae12ffd
Stack: