fix(codex): approve marketplace MCP tools by default#704
Merged
mksglu merged 1 commit intoMay 25, 2026
Conversation
NgoQuocViet2001
force-pushed
the
fix/codex-plugin-approval-mode
branch
from
May 25, 2026 05:29
ce1596d to
f14632f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Refs @Tomodad's Codex marketplace reports in #45:
The Codex marketplace MCP manifest does not set
default_tools_approval_mode, so context-mode MCP calls can enter Codex's approval/auto-review path before the tool runs. In the reported setup that path failed with a 503 before MCP execution.Fix
Add
default_tools_approval_mode: "approve"to.codex-plugin/mcp.jsonso Codex marketplace installs match the previously working manual MCP config behavior.Also adds a regression test for the Codex plugin manifest.
Validation
pnpm exec vitest run tests/core/cli.test.ts -t "Codex plugin MCP manifest"pnpm exec vitest run tests/core/cli.test.tspnpm run buildCODEX_HOME, no manual[mcp_servers.context-mode], installed the patched plugin through a Codex plugin path, then rancodex execand confirmedctx_statscompleted through thecontext-modeMCP server on v1.0.151.I could not reproduce the reporter's exact 503 locally; that looks provider/proxy-path-specific. This change avoids the approval/auto-review path for context-mode marketplace tools.
Separate note: I also found a Windows install blocker where
codex plugin add context-mode@context-modecan fail withmissing plugin.jsonbecauseplugins/context-modeis a symlink to... I kept that out of this PR because it is a separate install-path issue.