Skip to content

fix(codex): approve marketplace MCP tools by default#704

Merged
mksglu merged 1 commit into
mksglu:nextfrom
NgoQuocViet2001:fix/codex-plugin-approval-mode
May 25, 2026
Merged

fix(codex): approve marketplace MCP tools by default#704
mksglu merged 1 commit into
mksglu:nextfrom
NgoQuocViet2001:fix/codex-plugin-approval-mode

Conversation

@NgoQuocViet2001

Copy link
Copy Markdown
Contributor

Problem

Refs @Tomodad's Codex marketplace reports in #45:

The Codex marketplace MCP manifest does not set default_tools_approval_mode, so context-mode MCP calls can enter Codex's approval/auto-review path before the tool runs. In the reported setup that path failed with a 503 before MCP execution.

Fix

Add default_tools_approval_mode: "approve" to .codex-plugin/mcp.json so Codex marketplace installs match the previously working manual MCP config behavior.

Also adds a regression test for the Codex plugin manifest.

Validation

  • pnpm exec vitest run tests/core/cli.test.ts -t "Codex plugin MCP manifest"
  • pnpm exec vitest run tests/core/cli.test.ts
  • pnpm run build
  • Manual E2E: temp CODEX_HOME, no manual [mcp_servers.context-mode], installed the patched plugin through a Codex plugin path, then ran codex exec and confirmed ctx_stats completed through the context-mode MCP server on v1.0.151.
  • Control E2E: removing the field made the same tool call fall into the approval path and fail before result on my machine.

I could not reproduce the reporter's exact 503 locally; that looks provider/proxy-path-specific. This change avoids the approval/auto-review path for context-mode marketplace tools.

Separate note: I also found a Windows install blocker where codex plugin add context-mode@context-mode can fail with missing plugin.json because plugins/context-mode is a symlink to ... I kept that out of this PR because it is a separate install-path issue.

@NgoQuocViet2001
NgoQuocViet2001 force-pushed the fix/codex-plugin-approval-mode branch from ce1596d to f14632f Compare May 25, 2026 05:29
@mksglu
mksglu merged commit 115afc3 into mksglu:next May 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants