R code improvements from SISMID - #584
Merged
Merged
Conversation
Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
sbfnk
commented
Dec 2, 2025
Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
seabbs
approved these changes
Dec 2, 2025
seabbs
left a comment
Contributor
There was a problem hiding this comment.
It is wild. I see some linting issues but those may be common across code bases.
Contributor
Author
|
I've simplified the regex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_delays()more flexible with customizable distribution functions and parametersarray[]syntax matching innfidd-stan-tools.rfor Stan 2.26+save_warmupparameter tonfidd_sample()Closes #578