Use stdlib version of Map.update - #7130
Merged
Merged
Conversation
kit-ty-kate
approved these changes
Sep 7, 2026
kit-ty-kate
left a comment
Member
There was a problem hiding this comment.
lgtm aside from the following minor stylistic comments and the missing change to src/solver/opamBuiltinZ3.real.ml as shown in CI.
NathanReb
force-pushed
the
use-stdlib-update
branch
from
September 8, 2026 08:41
fba52b3 to
9e57b35
Compare
NathanReb
marked this pull request as ready for review
September 8, 2026 09:01
Collaborator
Author
|
Does the windows CI failure seem related to you @kit-ty-kate @rjbou ? |
Member
No it's not related. That's #6890 |
kit-ty-kate
reviewed
Sep 8, 2026
Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
rjbou
force-pushed
the
use-stdlib-update
branch
from
September 14, 2026 09:27
b945f56 to
fc5ee00
Compare
rjbou
approved these changes
Sep 14, 2026
rjbou
left a comment
Collaborator
There was a problem hiding this comment.
thanks!
looking at dependencies jobs, this change broke odep & opam-dune-lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4915