Conversation
rjbou
commented
Sep 14, 2026
| (None, OpamStd.String.Map.empty) | ||
| |> snd | ||
| List.fold_left (fun dbl elem -> | ||
| OpamStd.String.Map.update (to_str elem) |
Collaborator
Author
There was a problem hiding this comment.
we could have OpamStd.MAP as an argument too have a proper map, but we would need to create the map for OpamHash.kind locally, or in the module, just for this use case.
kit-ty-kate
force-pushed
the
check-double-lint
branch
from
September 14, 2026 10:42
18c5f2d to
99acdee
Compare
kit-ty-kate
reviewed
Sep 14, 2026
Comment on lines
419
to
420
| if OpamStd.String.Map.is_empty double then false, None else | ||
| true, |
Member
There was a problem hiding this comment.
while we're simplifying this function, i think returning a tuple here is redundant (fst = Option.is_some snd)
Comment on lines
422
to
423
| Printf.sprintf "%s: %d occurence%s" | ||
| elem occ (if occ = 1 then "" else "s")) |
Member
There was a problem hiding this comment.
same here, this check is superfluous:
Suggested change
| Printf.sprintf "%s: %d occurences" | |
| elem occ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen while reviewing #7130, queued on it