Skip to content

Conversation

@driusan
Copy link
Collaborator

@driusan driusan commented Jan 16, 2024

Pull v24.1.x forward into v25.

DO NOT SQUASH.

charlottesce and others added 12 commits November 7, 2023 13:30
Inactive users are not displayed in dropdowns to assign / watch an issue.
Skip over metadatafields and calculate ages in surveys

This is not a big change, one way or another the fields were either being skipped with an empty check, through a project override or through code in the module itself handling the submission. this is just an explicit check to make everything clearer
This fixes a bug in the fix_candidate_age.php script where it is getting CommentIDs from every instrument for each instrument, instead of just getting commentIDs for that instrument. This is making the script take n times as long where n = the number of instruments on the project.
…ng instrument. (aces#8903)

A try catch block was added to prevent the module to break if for any reason one of the instruments could not be instantiated. Resolves aces#8902
Add fields to XIN validation which are not parts of groups
- Adds a width prop to Modal so that it can be changed from the default 700px
- Backport from main branch. This would be used in CCNA v24.1 upgrade.
Fix bug where if a user has the same full name as another user, the examiner sites from the other user will show up in the edit user page.
…ces#8480)

Made the name column a link for downloading. Note: This module needs refactoring of the upload and download logic to be more robust.

    Resolves aces#7594
…odule ID (aces#8677)

This single use tool https://github.com/aces/Loris/blob/main/tools/single_use/Convert_LorisMenuID_to_ModuleID.php failed to convert the now deprecated LorisMenuID to the current modules table ModuleID for rows in issues_history table. The histories now refer to old LorisMenuIDs which map to the wrong module in the new modules table. This fixes this discrepancy by providing a patch, fixing the raisinbread dataset , and updating the conversion tool.

How this should be used for existing projects:

- If project upgraded to 23.0 and so already ran the Convert_LorisMenuID_to_ModuleID.php script, the project should run the patch SQL/New_patches/2023-04-25-FixIssueWrongModuleID.sql
Fixed issue where the assignee dropdown did not show the current assignee
Emails users who were added as watching
When a comment is added, it adds it to the email to everyone watching
Fix visit level feedback not showing up in behavioural_qc module. The visit Level feedback is now included as part of the formatColumn() function in the BehaviouralFeedback class.
@driusan driusan changed the base branch from main to 25.0-release January 16, 2024 18:28
@driusan driusan merged commit ea3cd85 into aces:25.0-release Jan 16, 2024
@ridz1208 ridz1208 added this to the Branch Maintenance milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants