-
Notifications
You must be signed in to change notification settings - Fork 189
Push v24.1.6 changes into 25 branch #9013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inactive users are not displayed in dropdowns to assign / watch an issue.
Skip over metadatafields and calculate ages in surveys This is not a big change, one way or another the fields were either being skipped with an empty check, through a project override or through code in the module itself handling the submission. this is just an explicit check to make everything clearer
This fixes a bug in the fix_candidate_age.php script where it is getting CommentIDs from every instrument for each instrument, instead of just getting commentIDs for that instrument. This is making the script take n times as long where n = the number of instruments on the project.
Add fields to XIN validation which are not parts of groups
- Adds a width prop to Modal so that it can be changed from the default 700px - Backport from main branch. This would be used in CCNA v24.1 upgrade.
Fix bug where if a user has the same full name as another user, the examiner sites from the other user will show up in the edit user page.
…odule ID (aces#8677) This single use tool https://github.com/aces/Loris/blob/main/tools/single_use/Convert_LorisMenuID_to_ModuleID.php failed to convert the now deprecated LorisMenuID to the current modules table ModuleID for rows in issues_history table. The histories now refer to old LorisMenuIDs which map to the wrong module in the new modules table. This fixes this discrepancy by providing a patch, fixing the raisinbread dataset , and updating the conversion tool. How this should be used for existing projects: - If project upgraded to 23.0 and so already ran the Convert_LorisMenuID_to_ModuleID.php script, the project should run the patch SQL/New_patches/2023-04-25-FixIssueWrongModuleID.sql
Fixed issue where the assignee dropdown did not show the current assignee Emails users who were added as watching When a comment is added, it adds it to the email to everyone watching
Fix visit level feedback not showing up in behavioural_qc module. The visit Level feedback is now included as part of the formatColumn() function in the BehaviouralFeedback class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull v24.1.x forward into v25.
DO NOT SQUASH.