Improve typing of return from decompileTransactionMessageFetchingLookupTables #1133
+89
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 17, 2025
BundleMonUnchanged files (136)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-4mkq3lw0b-anza-tech.vercel.app |
steveluscher
approved these changes
Dec 17, 2025
| TransactionMessageWithBlockhashLifetime, | ||
| TransactionMessageWithFeePayer, | ||
| TransactionMessageWithLifetime, | ||
| } from '..'; |
Collaborator
There was a problem hiding this comment.
As in the first PR in the stack, change this to import from the relevant modules.
901a7cd to
d76d1f2
Compare
7e05e9b to
091a9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we use
decompileTransactionMessageFetchingLookupTables, we get aBaseTransactionMessage, which is not a union type and therefore doesn't play nicely with Typescript type narrowing by version.Summary of Changes
decompileTransactionMessageFetchingLookupTablesPart of a stack that eventually supersedes #1103