Remove BaseTransactionMessage from transaction-message blockhash functions #1134
+31
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 17, 2025
mcintyre94
commented
Dec 17, 2025
| 'lifetimeConstraint' | ||
| >; | ||
| export type ExcludeTransactionMessageLifetime<TTransactionMessage extends TransactionMessage> = | ||
| TTransactionMessage extends unknown ? Omit<TTransactionMessage, 'lifetimeConstraint'> : never; |
Member
Author
There was a problem hiding this comment.
Flagging this here, but this pattern is used a lot through the stack
This is a trick to make Typescript distribute over the union type, ie not collapse the version. We use it in this stack whenever we use Omit<TTransactionVersion, ...>
7ba1862 to
bd589ff
Compare
BundleMonUnchanged files (136)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
bd589ff to
875e87c
Compare
Contributor
|
Documentation Preview: https://kit-docs-7yl4lpth5-anza-tech.vercel.app |
901a7cd to
d76d1f2
Compare
875e87c to
6d29dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our
TransactionMessagefunctions operate onBaseTransactionMessageinstead ofTransactionMessage, which limits the ability to type narrow the resulting transaction messagesSummary of Changes
TransactionMessagein input/output typesPart of a stack that eventually supersedes #1103