Add a typetest for types flowing through transaction message functions #1139
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d5eb6f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Dec 17, 2025
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 17, 2025
4c779df to
8342c4b
Compare
530dfbe to
9308170
Compare
8342c4b to
591e4e4
Compare
BundleMonUnchanged files (136)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-3ycmuupzm-anza-tech.vercel.app |
9308170 to
be1d465
Compare
591e4e4 to
b59f5dc
Compare
mcintyre94
commented
Dec 17, 2025
| '@solana/instruction-plans': minor | ||
| '@solana/transactions': minor | ||
| '@solana/signers': minor | ||
| '@solana/kit': minor |
Member
Author
There was a problem hiding this comment.
Flagging this - I think this is debatable on minor or major. TransactionMessage is compatible with BaseTransactionMessage, so app code isn't going to break. But if you have functions/types that use BaseTransactionMessage you may need to change them to use TransactionMessage in order to be compatible with our helper functions.
steveluscher
approved these changes
Dec 18, 2025
packages/kit/src/__typetests__/scenarios/transaction-message-decompile-modify-typetest.ts
Outdated
Show resolved
Hide resolved
be1d465 to
dfb68fb
Compare
b59f5dc to
401bd1f
Compare
dfb68fb to
fe00744
Compare
f4ff4f7 to
cecbf6d
Compare
fe00744 to
d5eb6f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new typetest that does the following:
decompileTransactionMessageFetchingLookupTablesNote that we don't have any typetests like this that combine functionality from multiple packages. I've put this in
packages/kit/__typetests__/scenarios, but don't feel strongly about where it should live. I do think it's important to have this as part of the repo though because it would be very easy to introduce a regression.Supersedes #1103, by avoiding the need to introduce assertion functions