Skip to content

feat(ops): support instance-template volume expansion on release-1.1 - #10943

Open
leon-ape wants to merge 4 commits into
release-1.1from
support/release-1.1-volume-expansion-instances-v2
Open

leon-ape wants to merge 4 commits into
release-1.1from
support/release-1.1-volume-expansion-instances-v2

Conversation

@leon-ape

@leon-ape leon-ape commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Backport instance-template-scoped VolumeExpansion to release-1.1 without the main branch owner-observation migration.

  • Add spec.volumeExpansion[].instances[] for ordinary components and sharding.template.instances.
  • Materialize inherited instance VCTs before changing storage.
  • Keep release-1.1 PVC-based expansion and progress tracking.
  • Avoid double counting when component and instance targets overlap.
  • Validate instance names, effective VCT names, storage growth, StorageClass support, and heterogeneous shard limits.
  • Update OpsRequest CRDs, API docs, sample, and release-1.1 tests.

Closes #10922

Validation

  • make generate
  • make manifests
  • make lint
  • scripts/codex-go-test.sh ./apis/operations/v1alpha1 -count=1
  • scripts/codex-go-test.sh ./pkg/operations -run '^TestVolumeExpansionInstanceActionMaterializesInheritedVCT$' -count=1
  • hack/license/header-check.sh

The full operations envtest suite could not start locally because the configured envtest cache directory is not writable; the PR CI will run the complete release-1.1 test suite.

@leon-ape
leon-ape requested review from a team and wangyelei as code owners September 22, 2026 10:16
@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 22, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.46875% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.07%. Comparing base (c4026cf) to head (03d7556).

Files with missing lines Patch % Lines
apis/operations/v1alpha1/opsrequest_validation.go 0.00% 64 Missing ⚠️
pkg/operations/volume_expansion.go 60.93% 21 Missing and 4 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1   #10943      +/-   ##
===============================================
- Coverage        56.10%   56.07%   -0.04%     
===============================================
  Files              550      550              
  Lines            62615    62714      +99     
===============================================
+ Hits             35132    35165      +33     
- Misses           24170    24234      +64     
- Partials          3313     3315       +2     
Flag Coverage Δ
unittests 56.07% <30.46%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nopick Not auto cherry-pick when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants