Skip to content

Use a circle for the ball in Breakout #4324

Closed

Description

@alice-i-cecile

Once #3730 is merged, we should represent the ball as a circle, rather than a square. We can probably stick with the AABB collision though for simplicity.

Activity

  1. added
    C-ExamplesAn addition or correction to our examples
    S-BlockedThis cannot move forward until something else changes
    on Mar 24, 2022
  2. rparrett commented on Mar 24, 2022

    @rparrett
    Contributor

    I have a feeling that in practice, not doing proper circle-aabb collision would end up looking pretty janky, but I'd personally love to see that if it doesn't complicate the example too much.

  3. mockersf commented on Mar 27, 2022

    @mockersf
    Member

    as a side note, this could already be done by using a round image, like https://github.com/bevyengine/bevy/blob/main/assets/branding/icon.png

  4. added
    D-TrivialNice and easy! A great choice to get started with Bevy
    and removed
    S-BlockedThis cannot move forward until something else changes
    on May 5, 2022
  5. alice-i-cecile commented on May 5, 2022

    @alice-i-cecile
    MemberAuthor

    #3730 is merged so this is now quite easy :)

  6. tkgalk commented on Aug 11, 2022

    @tkgalk
    Contributor

    I made a PR pretty much exactly the same as the #4682, if there is no answer from the creator of that PR, I can submit mine if you wish.

  7. alice-i-cecile commented on Aug 11, 2022

    @alice-i-cecile
    MemberAuthor

    Yes please @galkowskit :) Just link to the other PR and we'll credit you both.

  8. tkgalk commented on Aug 11, 2022

    @tkgalk
    Contributor
  9. rparrett commented on Aug 11, 2022

    @rparrett
    Contributor

    So the obvious collision "corner case" is this sort of thing:

    corner-case-heh.mov

    We could

    1. Have a circle with slightly wrong collisions
    2. Have a square with better collisions
    3. Fix the collision code

    I have a slight preference for 2 but it seems like fixing the collision code would be sort of involved, so I suppose I don't really mind 1.

  10. tkgalk commented on Aug 11, 2022

    @tkgalk
    Contributor

    I think it also touches the physics issue. There is a very rudimentary code for reflections.

  11. added a commit that references this issue on Aug 16, 2022
    f9104b7
  12. added a commit that references this issue on Sep 28, 2022
    01cf9f3
  13. added a commit that references this issue on Oct 28, 2022
    3e16946
  14. added a commit that references this issue on Feb 1, 2023
    9aae515
  15. AlexBrodbelt commented on May 15, 2023

    @AlexBrodbelt

    Hi, I'm trying to make a (modified) billiards game and need to detect to collision between balls. I was wondering if there already exists an implementation within bevy or whether I should make my own (and if its good/suitable enough I can contribute it back to bevy?). I've never contributed before so I'm not sure how this works. Thank you!

  16. mockersf commented on May 15, 2023

    @mockersf
    Member

    Bevy currently only has Axis Aligned Bounding Box for collisions, which probably wouldn't work very well for billiard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-ExamplesAn addition or correction to our examplesD-TrivialNice and easy! A great choice to get started with Bevy

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions