Skip to content

Improve bevy::audio::Decodable documentation #6361

Closed

Description

@harudagondi

How can Bevy's documentation be improved?

In Decodable, the documentation is very unclear, circular, and does not describe the actual functionality of the trait and its associated types.

Decodable is a type that can be converted to a rodio::Source type. It is usually paired with the Asset type from bevy_asset, and therefore must be Send, Sync, and implement TypeUuid. Generally this is raw sound data that can be converted to an iterator of samples.

Decodable::Decoder is an iterator of samples. In rodio, this is an iterator of u16, i16, and f32. See rodio::Source for more information.

Decodable::DecoderItem is simply an audio sample. It is usually u16, i16, or f32. See rodio::Sample for more information.

Decoder::decoder generates the iterator from the implementing type.

(Additionally, rodio::Source and rodio::Sample traits are not linked in the docs. To solve this, #5876 must be fixed)

Activity

  1. added
    C-DocsAn addition or correction to our documentation
    S-Needs-TriageThis issue needs to be labelled
    on Oct 25, 2022
  2. added
    A-AudioSounds playback and modification
    and removed
    S-Needs-TriageThis issue needs to be labelled
    on Oct 25, 2022
  3. dis-da-mor commented on Nov 16, 2022

    @dis-da-mor
    Contributor

    Working on this.

  4. moved this from Open to In Progress in Audio (Old)on Nov 17, 2022
  5. added a commit that references this issue on Jan 17, 2023
    0df67cd
  6. moved this from In Progress to Done in Audio (Old)on Jan 17, 2023
  7. added a commit that references this issue on Jan 22, 2023
    4ef9d6b
  8. added a commit that references this issue on Feb 1, 2023
    688e932
  9. added a commit that references this issue on Mar 4, 2023
    76b8829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-AudioSounds playback and modificationC-DocsAn addition or correction to our documentation

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions