Skip to content

[Merged by Bors] - Fix SytemParam handling of Commands - #1899

Closed
DJMcNab wants to merge 1 commit into
bevyengine:mainfrom
DJMcNab:systemparam-commands
Closed

DJMcNab wants to merge 1 commit into
bevyengine:mainfrom
DJMcNab:systemparam-commands

Conversation

@DJMcNab

@DJMcNab DJMcNab commented Apr 12, 2021

Copy link
Copy Markdown
Member

Fixes #1896

@DJMcNab DJMcNab added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Apr 12, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 12, 2021
@cart

cart commented Apr 14, 2021

Copy link
Copy Markdown
Member

Ahh that explains it. Nice catch.

@cart

cart commented Apr 14, 2021

Copy link
Copy Markdown
Member

bors r+

bors Bot pushed a commit that referenced this pull request Apr 14, 2021
@bors

bors Bot commented Apr 15, 2021

Copy link
Copy Markdown

@bors bors Bot changed the title Fix SytemParam handling of Commands [Merged by Bors] - Fix SytemParam handling of Commands Apr 15, 2021
@bors bors Bot closed this Apr 15, 2021
@DJMcNab
DJMcNab deleted the systemparam-commands branch April 15, 2021 06:02
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commands can't insert components to spawned entities if injected via a SystemParam

3 participants