Skip to content

[Merged by Bors] - Some small changes related to run criteria piping - #3923

Closed
DJMcNab wants to merge 3 commits into
bevyengine:mainfrom
DJMcNab:pipe-yeet
Closed

[Merged by Bors] - Some small changes related to run criteria piping#3923
DJMcNab wants to merge 3 commits into
bevyengine:mainfrom
DJMcNab:pipe-yeet

Conversation

@DJMcNab

@DJMcNab DJMcNab commented Feb 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Remove the 'chaining' api, as it's peculiar

Implement the label traits for Box<dyn ThatTrait> (n.b. I'm not confident about this change, but it was the quickest path to not regressing)

Remove the need for '.system' when using run criteria piping

@DJMcNab
Some changes related to run criteria piping
e5495f0 
Remove the 'chaining' api, as it's peculiar

Implement the label traits for Box<dyn It>
(n.b., I'm not confident about this change, but it was
the quickest path to not regressing)

Remove the need for '`.system`' within that
@github-actions github-actions Bot added the S-Needs-Triage This issue needs to be labelled label Feb 12, 2022
@DJMcNab DJMcNab added A-ECS Entities, components, systems, and events M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Feb 12, 2022
TheRawMeatball
TheRawMeatball reviewed Feb 12, 2022
View reviewed changes
Comment thread crates/bevy_ecs/src/schedule/stage.rs Outdated
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 12, 2022
@DJMcNab DJMcNab added this to the Bevy 0.7 milestone Feb 24, 2022
@cart

cart commented Apr 7, 2022

Copy link
Copy Markdown
Member

bors r+

bors Bot pushed a commit that referenced this pull request Apr 7, 2022
@DJMcNab
Some small changes related to run criteria piping (#3923)
21a875d 
Remove the 'chaining' api, as it's peculiar

~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~

Remove the need for '`.system`' when using run criteria piping
@bors

bors Bot commented Apr 7, 2022

Copy link
Copy Markdown

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title Some small changes related to run criteria piping [Merged by Bors] - Some small changes related to run criteria piping Apr 7, 2022
@bors bors Bot closed this Apr 7, 2022
@DJMcNab
DJMcNab deleted the pipe-yeet branch April 7, 2022 19:51
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@DJMcNab @aevyrie
Some small changes related to run criteria piping (bevyengine#3923)
adb8fb4 
Remove the 'chaining' api, as it's peculiar

~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~

Remove the need for '`.system`' when using run criteria piping
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@DJMcNab @ItsDoot
Some small changes related to run criteria piping (bevyengine#3923)
3b796ca 
Remove the 'chaining' api, as it's peculiar

~~Implement the label traits for `Box<dyn ThatTrait>` (n.b. I'm not confident about this change, but it was the quickest path to not regressing)~~

Remove the need for '`.system`' when using run criteria piping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes
+1 more reviewer
@TheRawMeatball TheRawMeatball TheRawMeatball approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

Bevy 0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@DJMcNab @cart @alice-i-cecile @TheRawMeatball