Repository navigation
Conversation
Davier
approved these changes
Nov 12, 2021
Davier
left a comment
Contributor
There was a problem hiding this comment.
The EntityRenderCommand, EntityPhaseItem and CachedPipelinePhaseItem traits look great. I will try them soon.
I haven't reviewed the custom_shader part.
It seems that the PR title needs updating, there are no PhaseItemRenderCommands
Member
Author
|
Oops good call @Davier! Updated to include the proper trait names. |
cart
force-pushed
the
entity-render-commands
branch
from
November 12, 2021 22:26
33a26a7 to
64239ea
Compare
Member
Author
|
(just renamed the commit ... no changes) |
Member
Author
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Nov 12, 2021
Adds new `EntityRenderCommand`, `EntityPhaseItem`, and `CachedPipelinePhaseItem` traits to make it possible to reuse RenderCommands across phases. This should be helpful for features like #3072 . It also makes the trait impls slightly less generic-ey in the common cases. This also fixes the custom shader examples to account for the recent Frustum Culling and MSAA changes (the UX for these things will be improved later).
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new
EntityRenderCommand,EntityPhaseItem, andCachedPipelinePhaseItemtraits to make it possible to reuse RenderCommands across phases. This should be helpful for features like #3072 . It also makes the trait impls slightly less generic-ey in the common cases.This also fixes the custom shader examples to account for the recent Frustum Culling and MSAA changes (the UX for these things will be improved later).