Repository navigation
[Merged by Bors] - bevy_reflect: remove glam from a test which is active without the glam feature - #5195
Closed
jakobhellermann wants to merge 1 commit into
Closed
[Merged by Bors] - bevy_reflect: remove glam from a test which is active without the glam feature#5195jakobhellermann wants to merge 1 commit into
glam from a test which is active without the glam feature#5195jakobhellermann wants to merge 1 commit into
Conversation
alice-i-cecile
approved these changes
Jul 4, 2022
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
I'm happy to merge this as trivial, ping me if I forget to come back to it.
mockersf
approved these changes
Jul 4, 2022
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
…lam feature (#5195) # Objective `glam` is an optional feature in `bevy_reflect` and there is a separate `mod test { #[cfg(feature = "glam")] mod glam { .. }}`. The `reflect_downcast` test is not in that module and doesn't depend on glam, which breaks `cargo test -p bevy_reflect` without the `glam` feature. ## Solution - Remove the glam types from the test, they're not relevant to it
glam from a test which is active without the glam featureglam from a test which is active without the glam feature
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…lam feature (bevyengine#5195) # Objective `glam` is an optional feature in `bevy_reflect` and there is a separate `mod test { #[cfg(feature = "glam")] mod glam { .. }}`. The `reflect_downcast` test is not in that module and doesn't depend on glam, which breaks `cargo test -p bevy_reflect` without the `glam` feature. ## Solution - Remove the glam types from the test, they're not relevant to it
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…lam feature (bevyengine#5195) # Objective `glam` is an optional feature in `bevy_reflect` and there is a separate `mod test { #[cfg(feature = "glam")] mod glam { .. }}`. The `reflect_downcast` test is not in that module and doesn't depend on glam, which breaks `cargo test -p bevy_reflect` without the `glam` feature. ## Solution - Remove the glam types from the test, they're not relevant to it
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…lam feature (bevyengine#5195) # Objective `glam` is an optional feature in `bevy_reflect` and there is a separate `mod test { #[cfg(feature = "glam")] mod glam { .. }}`. The `reflect_downcast` test is not in that module and doesn't depend on glam, which breaks `cargo test -p bevy_reflect` without the `glam` feature. ## Solution - Remove the glam types from the test, they're not relevant to it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
glamis an optional feature inbevy_reflectand there is a separatemod test { #[cfg(feature = "glam")] mod glam { .. }}.The
reflect_downcasttest is not in that module and doesn't depend on glam, which breakscargo test -p bevy_reflectwithout theglamfeature.Solution