Repository navigation
Conversation
mockersf
reviewed
Dec 17, 2022
Comment on lines
+371
to
+376
| extras: node | ||
| .mesh() | ||
| .and_then(|mesh| mesh.extras().as_ref()) | ||
| .map(|extras| super::GltfExtras { | ||
| value: extras.get().to_string(), | ||
| }), |
Member
There was a problem hiding this comment.
Those are not the node extras, those are the node' mesh extras
Maybe add a extras field with the node extras, and a mesh_extras field with those from the mesh?
Contributor
Author
There was a problem hiding this comment.
Yes. Because nodes, meshes, primitives and materials can have extra properties, I added the appropriate fields to the Gltf structs
alradish
force-pushed
the
alradish/gltf_extras
branch
from
January 22, 2023 20:24
6bfd317 to
0598aad
Compare
alradish
marked this pull request as draft
January 22, 2023 20:39
alradish
force-pushed
the
alradish/gltf_extras
branch
from
January 26, 2023 17:40
2dc87aa to
1502ab3
Compare
alradish
marked this pull request as ready for review
January 26, 2023 17:52
|
Just wanted to add my support for having extras added to @mockersf did you still have any concerns? Is there anything I can do to help shepherd this through? |
mockersf
approved these changes
Feb 8, 2023
Member
Looks good to me, I'm just bad at managing my notifications... thanks for the ping! |
Member
|
bors try |
alice-i-cecile
approved these changes
Feb 13, 2023
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
This LGTM. Let's see if this can merge; those CI failures don't seem to be your fault.
bors r+
bors Bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
# Objective In our project we parse `GltfNode` from `*.gltf` file, and we need extra properties information from Blender. Right now there is no way to get this properties from GltfNode (only through query when you spawn scene), so objective of this PR is to add extra properties to `GltfNode` ## Solution Store extra properties inside `Gltf` structs --- ## Changelog - Add pub field `extras` to `GltfNode`/`GltfMesh`/`GltfPrimitive` which store extras - Add pub field `material_extras` to `GltfPrimitive` which store material extras
|
Pull request successfully merged into main. Build succeeded:
|
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 14, 2023
# Objective In our project we parse `GltfNode` from `*.gltf` file, and we need extra properties information from Blender. Right now there is no way to get this properties from GltfNode (only through query when you spawn scene), so objective of this PR is to add extra properties to `GltfNode` ## Solution Store extra properties inside `Gltf` structs --- ## Changelog - Add pub field `extras` to `GltfNode`/`GltfMesh`/`GltfPrimitive` which store extras - Add pub field `material_extras` to `GltfPrimitive` which store material extras
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
# Objective In our project we parse `GltfNode` from `*.gltf` file, and we need extra properties information from Blender. Right now there is no way to get this properties from GltfNode (only through query when you spawn scene), so objective of this PR is to add extra properties to `GltfNode` ## Solution Store extra properties inside `Gltf` structs --- ## Changelog - Add pub field `extras` to `GltfNode`/`GltfMesh`/`GltfPrimitive` which store extras - Add pub field `material_extras` to `GltfPrimitive` which store material extras
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
In our project we parse
GltfNodefrom*.gltffile, and we need extra properties information from Blender. Right now there is no way to get this properties from GltfNode (only through query when you spawn scene), so objective of this PR is to add extra properties toGltfNodeSolution
Store extra properties inside
GltfstructsChangelog
extrastoGltfNode/GltfMesh/GltfPrimitivewhich store extrasmaterial_extrastoGltfPrimitivewhich store material extras