Skip to content

[Merged by Bors] - fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like… - #7520

Closed
rustyfan wants to merge 1 commit into
bevyengine:mainfrom
rustyfan:main
Closed

[Merged by Bors] - fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like…#7520
rustyfan wants to merge 1 commit into
bevyengine:mainfrom
rustyfan:main

Conversation

@rustyfan

@rustyfan rustyfan commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

Implementing GetTypeRegistration in macro impl_reflect_for_veclike! had typos!
It only implement GetTypeRegistration for Vec, but not for VecDeque.
This will cause serialization and deserialization failure.

@rustyfan
fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like…
c6d9ef4 
… object, it only implements for Vec<T>, but not
@github-actions

github-actions Bot commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

MrGVSV
MrGVSV approved these changes Feb 6, 2023
View reviewed changes

@MrGVSV MrGVSV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, great catch!

@MrGVSV MrGVSV added C-Bug An unexpected or incorrect behavior A-Reflection Runtime information about types labels Feb 6, 2023
@MrGVSV MrGVSV added this to the 0.10 milestone Feb 6, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 6, 2023
@mockersf

mockersf commented Feb 6, 2023

Copy link
Copy Markdown
Member

bors r+

bors Bot pushed a commit that referenced this pull request Feb 6, 2023
@rustyfan
fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like… (
4fd092f 
#7520)

Implementing GetTypeRegistration in macro impl_reflect_for_veclike! had typos!
It only implement GetTypeRegistration for Vec<T>, but not for VecDeque<T>.
This will cause serialization and deserialization failure.
@bors

bors Bot commented Feb 6, 2023

Copy link
Copy Markdown

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like… [Merged by Bors] - fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like… Feb 6, 2023
@bors bors Bot closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes
@mockersf mockersf mockersf approved these changes
+2 more reviewers
@jakobhellermann jakobhellermann jakobhellermann approved these changes
@MrGVSV MrGVSV MrGVSV approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Reflection (Old)
Status: Done

Milestone

0.10

Development

Successfully merging this pull request may close these issues.

5 participants

@rustyfan @mockersf @james7132 @jakobhellermann @MrGVSV