Repository navigation
[Merged by Bors] - Allow adding systems to multiple sets that share the same base set - #7709
Closed
geieredgar wants to merge 2 commits into
Closed
geieredgar wants to merge 2 commits into
geieredgar wants to merge 2 commits into
Conversation
alice-i-cecile
approved these changes
Feb 16, 2023
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Good tests, good fix. Thanks!
joseph-gio
approved these changes
Feb 16, 2023
Member
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded:
|
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 16, 2023
…evyengine#7709) # Objective Fixes bevyengine#7702. ## Solution - Added an test that ensures that no error is returned if a system or set is inside two different sets that share the same base set. - Added an check to only return an error if the two base sets are not equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #7702.
Solution