Repository navigation
[Merged by Bors] - make ScheduleGraph::initialize public - #7723
Closed
jakobhellermann wants to merge 1 commit into
Closed
jakobhellermann wants to merge 1 commit into
jakobhellermann wants to merge 1 commit into
Conversation
alice-i-cecile
approved these changes
Feb 17, 2023
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
follow-up to #7716 # Objective System access is only populated in `System::initialize`, so without calling `initialize` it's actually impossible to see most ambiguities. ## Solution - make `initialize` public. The method is idempotent, so calling it multiple times doesn't hurt
|
Pull request successfully merged into main. Build succeeded:
|
ScheduleGraph::initialize publicScheduleGraph::initialize public
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 18, 2023
follow-up to bevyengine#7716 # Objective System access is only populated in `System::initialize`, so without calling `initialize` it's actually impossible to see most ambiguities. ## Solution - make `initialize` public. The method is idempotent, so calling it multiple times doesn't hurt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #7716
Objective
System access is only populated in
System::initialize, so without callinginitializeit's actually impossible to see most ambiguities.Solution
initializepublic. The method is idempotent, so calling it multiple times doesn't hurt